ADD: "last played" sort option to TV Show GUI #1660

Merged
merged 1 commit into from Feb 3, 2013

Conversation

Projects
None yet
5 participants
@koying
Contributor

koying commented Oct 22, 2012

No description provided.

@Fneufneu

This comment has been minimized.

Show comment
Hide comment
@Fneufneu

Fneufneu Oct 23, 2012

Member

Cool feature, why it's only for tv show ? can be usefull for movies to.

Member

Fneufneu commented Oct 23, 2012

Cool feature, why it's only for tv show ? can be usefull for movies to.

@koying

This comment has been minimized.

Show comment
Hide comment
@koying

koying Jan 31, 2013

Contributor

@jmarshallnz Could you have a look, please.
I don't think adding this sort option to movies makes a lot of sense...

Contributor

koying commented Jan 31, 2013

@jmarshallnz Could you have a look, please.
I don't think adding this sort option to movies makes a lot of sense...

@jmarshallnz

This comment has been minimized.

Show comment
Hide comment
@jmarshallnz

jmarshallnz Jan 31, 2013

Member

Code looks good to me. Only question is if it should be applied to other cases. Does lastplayed get updated when something is only half watched?

Member

jmarshallnz commented Jan 31, 2013

Code looks good to me. Only question is if it should be applied to other cases. Does lastplayed get updated when something is only half watched?

@koying

This comment has been minimized.

Show comment
Hide comment
@koying

koying Feb 2, 2013

Contributor

Re cases, I don't see a use case for movies or episodes. Might be interesting for artists/albums, maybe?
Re updated, lastplayed is based on playcount, IIRC.
@Montellese could probably tell when a file is considered as "played".

Contributor

koying commented Feb 2, 2013

Re cases, I don't see a use case for movies or episodes. Might be interesting for artists/albums, maybe?
Re updated, lastplayed is based on playcount, IIRC.
@Montellese could probably tell when a file is considered as "played".

@Montellese

This comment has been minimized.

Show comment
Hide comment
@Montellese

Montellese Feb 2, 2013

Member

IIRC lastplayed is not updated when a video is not finished i.e. if lastplayed is updated, playcount is updated as well.

Member

Montellese commented Feb 2, 2013

IIRC lastplayed is not updated when a video is not finished i.e. if lastplayed is updated, playcount is updated as well.

@koying

This comment has been minimized.

Show comment
Hide comment
@koying

koying Feb 2, 2013

Contributor

It's the other way around, I think. lastplayed is based upon playcount. JM's question is when is the playcount updated...

Contributor

koying commented Feb 2, 2013

It's the other way around, I think. lastplayed is based upon playcount. JM's question is when is the playcount updated...

@Montellese

This comment has been minimized.

Show comment
Hide comment
@Montellese

Montellese Feb 2, 2013

Member

Nope you can have a playcount of 0 (by marking a video as unwatched) but you can still have a lastplayed value so that statement is not correct.

Member

Montellese commented Feb 2, 2013

Nope you can have a playcount of 0 (by marking a video as unwatched) but you can still have a lastplayed value so that statement is not correct.

@koying

This comment has been minimized.

Show comment
Hide comment
@koying

koying Feb 2, 2013

Contributor

My mistake. I mixed up things.
Am I right assuming the lastplayed field is updated at the same time as playcount is set to 1?

Contributor

koying commented Feb 2, 2013

My mistake. I mixed up things.
Am I right assuming the lastplayed field is updated at the same time as playcount is set to 1?

@MartijnKaijser

This comment has been minimized.

Show comment
Hide comment
@MartijnKaijser

MartijnKaijser Feb 2, 2013

Member

Even if you haven't finished it so playcount stays zero but last played time is still updated.

Member

MartijnKaijser commented Feb 2, 2013

Even if you haven't finished it so playcount stays zero but last played time is still updated.

@koying

This comment has been minimized.

Show comment
Hide comment
@koying

koying Feb 2, 2013

Contributor

OK. So answer to @jmarshallnz is: It is updated as soon as playback starts ;)

Contributor

koying commented Feb 2, 2013

OK. So answer to @jmarshallnz is: It is updated as soon as playback starts ;)

@MartijnKaijser

This comment has been minimized.

Show comment
Hide comment
@MartijnKaijser

MartijnKaijser Feb 2, 2013

Member

Or on stops. Not sure (tm)

Member

MartijnKaijser commented Feb 2, 2013

Or on stops. Not sure (tm)

@jmarshallnz

This comment has been minimized.

Show comment
Hide comment
@jmarshallnz

jmarshallnz Feb 2, 2013

Member

Righto - merge at your leisure then.

Member

jmarshallnz commented Feb 2, 2013

Righto - merge at your leisure then.

koying added a commit that referenced this pull request Feb 3, 2013

Merge pull request #1660 from koying/tvshowsortbylastplayed
ADD: "last played" sort option to TV Show GUI

@koying koying merged commit c9accb2 into xbmc:master Feb 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment