Update docs/README.android #1663

Merged
merged 1 commit into from Oct 24, 2012

Conversation

Projects
None yet
3 participants
Contributor

maheus commented Oct 24, 2012

add cmake in apt-get for compile TagLib

MakeFile in taglib directory line 25:
cd $(SOURCE)/build; cmake .. -DCMAKE_INSTALL_PREFIX=/usr/local -DENABLE_STATIC=1

maheus Update docs/README.android
add cmake in apt-get for compile TagLib 

MakeFile in taglib directory line 25:
 cd $(SOURCE)/build; cmake .. -DCMAKE_INSTALL_PREFIX=/usr/local -DENABLE_STATIC=1
a3a6ffd

Memphiz merged commit 0cbe4df into xbmc:master Oct 24, 2012

Owner

Memphiz commented Oct 24, 2012

thx

Owner

maheus commented on a3a6ffd Oct 24, 2012

Wrong Makefile , in fact it's line 19 :

Member

theuni replied Oct 24, 2012

This is not needed, we build cmake.

Need to fix the dep map instead. You recall where it busted?

Member

theuni replied Oct 24, 2012

Hah. Missed the commit msg entirely.

Member

theuni replied Oct 24, 2012

Ok, to verify, I added an 'echo which cmake' to the taglib Makefile, and got the expected result:

cory@cory-i7:/build/xbmc/tools/android/depends/taglib(master)$ make
echo `which cmake`
/opt/android/android-ndk-r7-crystax-5.beta2-toolchain/staging/armeabi-v7a-native/bin/cmake

So this really should not be needed.

Member

theuni replied Oct 24, 2012

Continuing my monologue. Whatever the problem, this should take care of it: https://gist.github.com/3946168

Contributor

maheus replied Oct 24, 2012

Contributor

maheus replied Oct 24, 2012

Owner

Memphiz replied Oct 24, 2012

Damn sorry for messing/merging in your area theuni ...

Member

theuni replied Oct 24, 2012

@Memphiz No worries at all, it's certainly not "my" area :)

If we're falling back to system cmake, it's a bug because different builders will generate different builds. So we need to be sure that our self-built cmake works.

That's the only reason I'm being picky.

Member

theuni commented Oct 24, 2012

@maheus did you have to apt-get cmake to build?

Contributor

maheus commented Oct 24, 2012

yes but i totaly recompile xbmc so I think it was unnecessary .
I don't no my first compilation not perform .

Message du 24/10/12 à 18h12
De : "Cory Fields"
A : "xbmc/xbmc"
Copie à : "maheus"
Objet : Re: [xbmc] Update docs/README.android (#1663)

@maheus did you have to apt-get cmake to build?

Reply to this email directly or view it on GitHub.


L'étonnant soutien de Michel Drucker au cycliste déchu Lance Armstrong… à lire sur Voila.fr http://people.voila.fr/people/actu-stars/personnalites/polemique-de-la-semaine-michel-drucker-etonne-en-soutenant-lance-armstrong-people_8786.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment