[rendering] fixed reverted ff1b2128bf7d9dca3a2d933332a83886ddb8cf72 and ... #1676

Merged
merged 1 commit into from Oct 26, 2012

Conversation

Projects
None yet
3 participants
Contributor

huceke commented Oct 25, 2012

...fix it proper fixed #13434 , #13419 and 13435. Thx cptspiff.

Link to the deadlock : http://xbmclogs.com/show.php?id=11365

Contributor

huceke commented Oct 25, 2012

@jmarshallnz: updated the PR to be more compatible to the current master version.

Contributor

huceke commented Oct 26, 2012

@jmarshallnz : Added the window id to SendThreadMessage.

@jmarshallnz jmarshallnz and 1 other commented on an outdated diff Oct 26, 2012

xbmc/windows/GUIWindowHome.cpp
else
- m_updateRA |= (Video | Audio | Totals);
+ {
+ if (IsActive())
+ AddRecentlyAddedJobs(Video | Audio | Totals);
+ else
+ m_updateRA |= (Video | Audio | Totals);
+ }
@jmarshallnz

jmarshallnz Oct 26, 2012

Member

Alternate is:

int updateRA = (message.GetSenderId() == GetID()) ? message.GetParam2() : (Video | Audio | Totals);
// update as per usual

@jmarshallnz

jmarshallnz Oct 26, 2012

Member

yeah, a little cleaner I think?

Will this also resolve the deadlock in PVR ?

@ghost

ghost commented Oct 26, 2012

@FSSDawid if you have nothing to contribute to the discussion at hand, FUCK OFF! you are spamming hundreds of people every time you post to one of the pr's and this is NOT a support channel.

@jmarshallnz i considered that, but i can't think of a single reason another window would send us that msg when we are active. can you or just being defensive? then again, it surely won't hurt doing that way but diff grows ;)

Member

jmarshallnz commented Oct 26, 2012

Defensive. Airtunes server sends a GUI_MSG_REFRESH_THUMBS event, though that shouldn't affect things either way.

Contributor

huceke commented Oct 26, 2012

@jmarshallnz : squeezed it down ;)

huceke merged commit c71a102 into xbmc:master Oct 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment