Add ability to queue list of items without playing them #1679

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
Owner

koying commented Oct 26, 2012

This is related (but not dependent) on #1597.

It adds a means to add a list of items to a playlist without playing them

xbmc/music/windows/GUIWindowMusicPlaylistEditor.cpp
+ case CONTEXT_BUTTON_PLAY_WITH:
+ {
+ VECPLAYERCORES vecCores;
+ CPlayerCoreFactory::GetPlayers(*item, vecCores);
@elupus

elupus Oct 27, 2012

Member

item could be a null pointer here according to above.

Member

elupus commented Oct 27, 2012

The play with addition to playlists are quite nice and can be considered a fix for a lack of this from the start. The queue from here is more questionable if it's a fix.

It could potentially be usefull.. but it's nothing I can ack.

Owner

koying commented Oct 27, 2012

Well, one could argue that if "Queue current item" and "Play from here"
exists, "Queue from here" should have been there, too...

On 27 October 2012 16:41, Joakim Plate notifications@github.com wrote:

The play with addition to playlists are quite nice and can be considered a
fix for a lack of this from the start. The queue from here is more
questionable if it's a fix.

It could potentially be usefull.. but it's nothing I can ack.


Reply to this email directly or view it on GitHubhttps://github.com/xbmc/xbmc/pull/1679#issuecomment-9836000.

Owner

Montellese commented Oct 28, 2012

I kind of agree with elupus that the "play with" is IMO more crucial (I never use it but I can see the need for it) than the "Queue from here". In general the argument you are bringing forth would apply to any new feature because otherwise the feature wouldn't be included if it wasn't missing in the first place. I'd say spliting the two functionalities into two seperate PRs is the best way to go.

Owner

koying commented Oct 28, 2012

Np. Will create a separate "fix" for the "play using".
Le 28 oct. 2012 10:31, "Sascha Montellese" notifications@github.com a
écrit :

I kind of agree with elupus that the "play with" is IMO more crucial (I
never use it but I can see the need for it) than the "Queue from here". In
general the argument you are bringing forth would apply to any new feature
because otherwise the feature wouldn't be included if it wasn't missing in
the first place. I'd say spliting the two functionalities into two seperate
PRs is the best way to go.


Reply to this email directly or view it on GitHubhttps://github.com/xbmc/xbmc/pull/1679#issuecomment-9844059.

Owner

koying commented Oct 28, 2012

Removed the commit re "Play using" to PR #1689

Owner

koying commented Jan 31, 2013

@Montellese @elupus Clear to go?

Member

jmarshallnz commented Jan 31, 2013

I'm not sure what the use case is for this one? When do you want to queue from a certain item yet not play?

Owner

koying commented Feb 2, 2013

As said above, it is directly linked to @elupus PR which make XBMC a control point for other upnp renderers.
"Play from here" does not allow to specify the player, so that would be the only way to have a playlist sent to a remote renderer, selecting the distant player from the playlist viewer.

Member

jmarshallnz commented Feb 2, 2013

That's a bit of a clunky UI though (queue from here, switch to some playlist view I guess, then play using?) Wouldn't it be more natural if there was a way to specify "Play to foo" before playback (or while playback is occurring) so that the Play from here... sent it to that other device anyway? e.g. something similar to the way airplay works.

Member

elupus commented Feb 2, 2013

That is supported actually. You can swap player after starting. Bound to
the key Y in the patch.

You can't pre specify currently though.

Owner

koying commented Feb 3, 2013

Let's get @elupus one in first, then we'll see if this is needed...

@ghost ghost assigned elupus Oct 17, 2013

@koying koying closed this May 24, 2015

@MartijnKaijser MartijnKaijser modified the milestones: WIP / RFC (code improvements needed), Abandoned, obsolete or superseeded Jun 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment