Fix CCurlFile::Get() #1681

Merged
merged 1 commit into from Oct 27, 2012

Projects

None yet

5 participants

@Red-F

This fixes CCurlFile::Get() by moving the explicit initialisation of the request pre-conditions (used by CCurlFile::Open()) to CCurlFile::Post() resp. CCurlFile::Get()

See issues with PR #1650.

@Red-F Red-F Fix CCurlFile::Get() by moving the explicit initialisation of the req…
…uest pre-conditions to CCurlFile::Post() resp. CCurlFile::Get()
5a03f0b
@opdenkamp opdenkamp commented on the diff Oct 26, 2012
xbmc/filesystem/CurlFile.cpp
}
-bool CCurlFile::Service(const CStdString& strURL, const CStdString& strPostData, CStdString& strHTML)
+bool CCurlFile::Service(const CStdString& strURL, CStdString& strHTML)
@opdenkamp
opdenkamp Oct 26, 2012

this isn't needed?

@Red-F
Red-F Oct 26, 2012

Service was a private method only called by Post and Get. Since we initialise now at the location where we actually know if we're doing a get or post, this is indeed no longer needed.

@opdenkamp
opdenkamp Oct 26, 2012

oh wasn't talking about the method but about the const change. but if the method is no longer needed, then that's even better.

@huceke

@opdenkamp: This fixes a problem i have with scarping. ( http://pastebin.com/rBWJyvR0 )

@ryanroth

Ditto. I was having scrapping issues after the initial patch was committed.

@opdenkamp
Team Kodi member

yes i know

@jmarshallnz jmarshallnz merged commit 599a248 into xbmc:master Oct 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment