[pvr] bump android and darwin pvr add-ons #1685

Merged
merged 2 commits into from Oct 30, 2012

Conversation

Projects
None yet
2 participants
Member

opdenkamp commented Oct 27, 2012

bumps android + darwin pvr add-ons to opdenkamp/xbmc-pvr-addons@60b3cfb

please compile test, since i can't properly test those and some new add-ons were added and configure.ac was changed

Member

opdenkamp commented Oct 27, 2012

and i just noticed that this add-ons commit fails on linux too in a clean tree cause of a configure.ac change. will fix that and update this PR over the week end. sorry for the noise

Member

opdenkamp commented Oct 27, 2012

updated, compiles again. you may slap trouts cause i didn't fully clean before testing and submitting the PR

Owner

Memphiz commented Oct 27, 2012

compile and runtime tested on osx
compile and runtime tested on ios - i don't get the pvr addon to start:

http://pastebin.com/i2ebUCrx

no clue if its me, my buildsys or general problem. But what is error 6? Couldn't we show some more meaning full errors there?

doesn't compile for android with this error:

http://pastebin.com/NgnS81DK

casting the argument of localtime to (const time_t *) fixes the compilation (not sure why this is even needed here).

Owner

Memphiz commented Oct 27, 2012

Well we can maybe ignore the ios problem - cause i tried latest nightly from the buildbot and it works there. Just wonder what i do wrong when building it myself :/

Member

opdenkamp commented Oct 27, 2012

error 6 = ADDON_STATUS_PERMANENT_FAILURE, so probably unresolved symbols.

thanks for checking the android build. that can be fixed easiliy

Owner

Memphiz commented Oct 27, 2012

Runtime check on android was positiv aswell.

Also for osx/ios you can add " --enable-addons-with-dependencies" to the configure in the Makefile for enabling the mythtv.cmyth addon. Compiles fine on these 2 platforms too.

Don't add it for droid - this needs some droid love from TheUni if this addon is needed.

Member

opdenkamp commented Oct 27, 2012

great thanks

Member

opdenkamp commented Oct 29, 2012

@Memphiz updated

Owner

Memphiz commented Oct 29, 2012

looks good

Owner

Memphiz commented Oct 29, 2012

Is the android build fix in this revision? (can't see it in the repo)

Member

opdenkamp commented Oct 29, 2012

ah, i knew i forgot something :)

Member

opdenkamp commented Oct 29, 2012

updated so it's cast to (const time_t *)

@opdenkamp opdenkamp added a commit that referenced this pull request Oct 30, 2012

@opdenkamp opdenkamp Merge pull request #1685 from opdenkamp/pvraddons
[pvr] bump android and darwin pvr add-ons
4fae651

@opdenkamp opdenkamp merged commit 4fae651 into xbmc:master Oct 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment