Skip to content

ADD: [droid] disable keyguard in addition to wakelock #1716

Closed
wants to merge 2 commits into from

5 participants

@koying
Team Kodi member
koying commented Nov 1, 2012

This allows to disable the keyguard, allowing, e.g. to shut down the display when listening to music and to return directly to xbmc without going thru the lock screen.

It is a matter of taste, really, but as a wake lock is implemented, this one seems logical, too

@Montellese
Team Kodi member

Are there any other players that allow this? Most video players change the power key into a screen lock (i.e. disabling all the other screens) but still show the video playback. Music players usually don't have a wakelock at all because they don't have anything to display.

@Memphiz
Team Kodi member
Memphiz commented Oct 12, 2013

vdrfan told me that you should be able to control players when the mobile is locked. So something like on iphone where there are player controls in the lockscreen so you can still control it without unlocking. @koying i guess this would need alot of work right? (iirc ulion did that for ios)

@Montellese
Team Kodi member

IIRC on android you need a service to be able to control playback from somewhere else and that would require a major rewrite of xbmc to split it up.

@davilla
davilla commented Oct 12, 2013

this need to follow our jni model and a KeyguardManager class created to handle it instead of raw jni in XBMCApp

@koying
Team Kodi member
@Montellese
Team Kodi member

If we don't want it, close it. As I said I'm not sure what the "expected" behaviour would be. IMO turning off the screen while playing a video doesn't make sense and when playing music I only used players that do not behave any different than other apps when turning off the screen (i.e. locking it).

@koying koying closed this Oct 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.