drop the videodb:// forced caching #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d hurts more than it helps. fixes xbmc#13466.
ghost
pushed a commit
that referenced
this pull request
Nov 1, 2012
drop the videodb:// forced caching
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It hurts more than it helps. Caching is already done at the window level for slow listings. Music library hasn't had this in effect for several years. Lastly, it wasn't even in effect in Eden due to the callback from the video thumb loader flushing it out all the time:
https://github.com/xbmc/xbmc/blob/Eden/xbmc/video/windows/GUIWindowVideoNav.cpp#L275
Fixes issues such as #13466, along with a bunch of others reported on forums.