Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

pvr: Added API function GetRecordingEdl #1743

Merged
merged 1 commit into from Mar 7, 2013

Conversation

Projects
None yet
7 participants
Member

fetzerch commented Nov 7, 2012

@dteirney: This will be probably of interest to you

This PR extends the PVR API with the function GetRecordingEdl to retreive edit decision lists from the backend.

In addition DVDPlayer's EDL class has been adapted to read the EDL from the backend for recordings.

A sample implementation for the MythTV PVR addon can be found here:
fetzerch/xbmc-pvr-addons@3c6738a

@ghost ghost assigned opdenkamp Nov 7, 2012

Member

wsoltys commented Nov 7, 2012

Nice. @FernetMenta I would love to see this in the vnsi client. Then #792 would make more sense. Though this is something for after frodo.

Member

FernetMenta commented Nov 7, 2012

@wsoltys I put it on my list.

@kentnielsen kentnielsen referenced this pull request in pipelka/vdr-plugin-xvdr Nov 8, 2012

Closed

Feature request: synchronize markad advertisement marks #25

Member

fetzerch commented Nov 10, 2012

@dteirney Thanks I fixed the logging. For the scene and the logging in PVRClients.cpp I added inline comments here:
fetzerch/xbmc@18c9e42

Member

dteirney commented Nov 11, 2012

The link in the previous comment points to the old commit. The new stuff at fetzerch/xbmc@a6019ac looks fine to me. Nice work.

I'm not sure why SCENE was taken out. I'll have to look at why some other time.

@opdenkamp over to you for review.

@fetzerch fetzerch referenced this pull request in fetzerch/xbmc-pvr-addons Nov 29, 2012

Merged

Edit decision list (EDL) #51

mtheli commented Dec 31, 2012

Is there any chance to get this feature into frodo?

Member

opdenkamp commented Dec 31, 2012

nope

pvr: Added API function GetRecordingEdl
This extends the PVR API with the function GetRecordingEdl
to retrieve edit decision lists from the PVR addon.

In addition, DVDPlayer's EDL class has been adapted to read the EDL
from the backend when starting playback of a recordings.

ryanolf commented Feb 5, 2013

I've been using this feature (from fetzerch's mainline branch https://github.com/fetzerch/xbmc/tree/mainline) with the mythtv-cmyth pvr addon (from https://github.com/fetzerch/xbmc-pvr-addons/tree/mainline) and it's worked very solidly. Now that frodo is out, maybe this is ready to be considered for merge into the xbmc master?

@fetzerch fetzerch referenced this pull request in opdenkamp/xbmc-pvr-addons Feb 16, 2013

Closed

GetRecordingEdl #173

Member

opdenkamp commented Feb 16, 2013

this one needs a version bump too. goes in with #2250

opdenkamp added a commit that referenced this pull request Mar 7, 2013

@opdenkamp opdenkamp merged commit 14c8987 into xbmc:master Mar 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment