Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pvr: Added API function GetRecordingEdl #1743

Merged
merged 1 commit into from Mar 7, 2013
Merged

Conversation

fetzerch
Copy link
Member

@fetzerch fetzerch commented Nov 7, 2012

@dteirney: This will be probably of interest to you

This PR extends the PVR API with the function GetRecordingEdl to retreive edit decision lists from the backend.

In addition DVDPlayer's EDL class has been adapted to read the EDL from the backend for recordings.

A sample implementation for the MythTV PVR addon can be found here:
fetzerch/xbmc-pvr-addons@3c6738a

@ghost ghost assigned opdenkamp Nov 7, 2012
@wsoltys
Copy link

wsoltys commented Nov 7, 2012

Nice. @FernetMenta I would love to see this in the vnsi client. Then #792 would make more sense. Though this is something for after frodo.

@FernetMenta
Copy link
Contributor

@wsoltys I put it on my list.

@fetzerch
Copy link
Member Author

@dteirney Thanks I fixed the logging. For the scene and the logging in PVRClients.cpp I added inline comments here:
fetzerch@18c9e42

@dteirney
Copy link
Contributor

The link in the previous comment points to the old commit. The new stuff at fetzerch@a6019ac looks fine to me. Nice work.

I'm not sure why SCENE was taken out. I'll have to look at why some other time.

@opdenkamp over to you for review.

@mtheli
Copy link

mtheli commented Dec 31, 2012

Is there any chance to get this feature into frodo?

@opdenkamp
Copy link
Member

nope

This extends the PVR API with the function GetRecordingEdl
to retrieve edit decision lists from the PVR addon.

In addition, DVDPlayer's EDL class has been adapted to read the EDL
from the backend when starting playback of a recordings.
@ryanolf
Copy link

ryanolf commented Feb 5, 2013

I've been using this feature (from fetzerch's mainline branch https://github.com/fetzerch/xbmc/tree/mainline) with the mythtv-cmyth pvr addon (from https://github.com/fetzerch/xbmc-pvr-addons/tree/mainline) and it's worked very solidly. Now that frodo is out, maybe this is ready to be considered for merge into the xbmc master?

@opdenkamp
Copy link
Member

this one needs a version bump too. goes in with #2250

opdenkamp added a commit that referenced this pull request Mar 7, 2013
@opdenkamp opdenkamp merged commit 14c8987 into xbmc:master Mar 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Feature non-breaking change which adds functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants