New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pvr: Added API function GetRecordingEdl #1743
Conversation
|
Nice. @FernetMenta I would love to see this in the vnsi client. Then #792 would make more sense. Though this is something for after frodo. |
|
@wsoltys I put it on my list. |
|
@dteirney Thanks I fixed the logging. For the scene and the logging in PVRClients.cpp I added inline comments here: |
|
The link in the previous comment points to the old commit. The new stuff at fetzerch@a6019ac looks fine to me. Nice work. I'm not sure why SCENE was taken out. I'll have to look at why some other time. @opdenkamp over to you for review. |
|
Is there any chance to get this feature into frodo? |
|
nope |
This extends the PVR API with the function GetRecordingEdl to retrieve edit decision lists from the PVR addon. In addition, DVDPlayer's EDL class has been adapted to read the EDL from the backend when starting playback of a recordings.
|
I've been using this feature (from fetzerch's mainline branch https://github.com/fetzerch/xbmc/tree/mainline) with the mythtv-cmyth pvr addon (from https://github.com/fetzerch/xbmc-pvr-addons/tree/mainline) and it's worked very solidly. Now that frodo is out, maybe this is ready to be considered for merge into the xbmc master? |
|
this one needs a version bump too. goes in with #2250 |
@dteirney: This will be probably of interest to you
This PR extends the PVR API with the function GetRecordingEdl to retreive edit decision lists from the backend.
In addition DVDPlayer's EDL class has been adapted to read the EDL from the backend for recordings.
A sample implementation for the MythTV PVR addon can be found here:
fetzerch/xbmc-pvr-addons@3c6738a