[pvr] Update internal naming of PVR items for better library integration (updated) #1747

Merged
1 commit merged into from Nov 12, 2012

Conversation

Projects
None yet
3 participants
Contributor

axmhari commented Nov 7, 2012

Change the internal path of PVR items to the following style
pvr://recordings//<title>, TV (), _.pvr

Updated version of #1728, see discussion there.

Member

jmarshallnz commented Nov 7, 2012

Looks OK to me, though I'd be tempted to drop the looking up in the recording manager if it doesn't provide anything the regexp does.

@opdenkamp you're probably better to comment on that.

Contributor

axmhari commented Nov 7, 2012

I though about dropping the look-up, too. I didn't do it, because the title may contain some characters, the filename does not. These are currently '/' and '?'. However, the replacement of '?' was only introduced, because there was a problem with scraping of titles containing a question mark. I think this replacement could be removed now. '/' is replaced by '-'. This can cause problems, e.g. "Face/Off".

We could replace '/' by a space instead, drop the question mark removal and then remove the recording look-up.

Member

jmarshallnz commented Nov 7, 2012

Sounds like a good way forward. Note that you can fix + rebase and force push back to your branch to update the PR.

@axmhari axmhari [pvr] Update internal naming of PVR items for better library integrat…
…ion.

It changes the internal path of PVR recordings to "pvr://recordings/<path>/<title>, TV (<channel>), <date>_<time>.pvr". This way XBMC has the same directory structure as the PVR server and some problems resulting from the previously used virtual date/time subdirectory are solved (e.g. availability of thumbnails and fanarts in "Files" view). To ensure proper scraping CFileItem::GetMovieName is changed to return the actual title instead of the filename for PVR recordings.
119cae6
Contributor

axmhari commented Nov 8, 2012

Note that you can fix + rebase and force push back to your branch to update the PR.

I see, thanks. The PR is updated.

opdenkamp was assigned Nov 8, 2012

Member

jmarshallnz commented Nov 8, 2012

@opdenkamp, @cptspiff over to you.

Member

opdenkamp commented Nov 9, 2012

checked & ok. over to @cptspiff :)

ghost was assigned Nov 9, 2012

@ghost ghost added a commit that referenced this pull request Nov 12, 2012

Arne Morten Kvarving Merge pull request #1747 from axmhari/pvr-file-path-reviewed
 [pvr] Update internal naming of PVR items for better library integration (updated)
f023c02

@ghost ghost merged commit f023c02 into xbmc:master Nov 12, 2012

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment