New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow internetstream video sources in a LAN to look for exernal subtitle files. #17491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good to me. Please remove the merge commit from this PR. |
Have removed merge commit. |
lrusak
added
Component: Video
Type: Improvement
non-breaking change which improves existing functionality
v19 Matrix
labels
Mar 17, 2020
jenkins build this please |
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 14, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 16, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
May 5, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 3, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Video
Type: Improvement
non-breaking change which improves existing functionality
v19 Matrix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
internetstream video sources (http, ftp etc) do not automatically look for subtitle files. This fix allows for internetstream video sources which are on a local LAN to look for subtitle files automatically. This is particularly important for forced external subtitle files.
internetstream video sources (http, ftp etc) do not automatically look for subtitle files. This fix allows for internetstream video sources which are on a local LAN to look for subtitle files automatically. This is particularly important for forced external subtitle files.
Motivation and Context
Allows for internetstream video sources which are on a local LAN to look for subtitle files automatically
How Has This Been Tested?
Recompiled with changed code. Version with changed code finds subtitle files for videos as per wiki - https://kodi.wiki/view/Subtitles#Manually_downloaded_external_subtitle_files.
Standard version without changed code does not.
Arch linux.
Version with changed code finds subtitle files for videos as per wiki - https://kodi.wiki/view/Subtitles#Manually_downloaded_external_subtitle_files.
Standard version without changed code does not.
It does not appear to.
Screenshots (if appropriate):
Types of change
Checklist: