Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow internetstream video sources in a LAN to look for exernal subtitle files. #17491

Merged
merged 1 commit into from Apr 12, 2020

Conversation

snaunton
Copy link
Contributor

Description

internetstream video sources (http, ftp etc) do not automatically look for subtitle files. This fix allows for internetstream video sources which are on a local LAN to look for subtitle files automatically. This is particularly important for forced external subtitle files.

internetstream video sources (http, ftp etc) do not automatically look for subtitle files. This fix allows for internetstream video sources which are on a local LAN to look for subtitle files automatically. This is particularly important for forced external subtitle files.

Motivation and Context

Allows for internetstream video sources which are on a local LAN to look for subtitle files automatically

How Has This Been Tested?

Recompiled with changed code. Version with changed code finds subtitle files for videos as per wiki - https://kodi.wiki/view/Subtitles#Manually_downloaded_external_subtitle_files.
Standard version without changed code does not.

Arch linux.
Version with changed code finds subtitle files for videos as per wiki - https://kodi.wiki/view/Subtitles#Manually_downloaded_external_subtitle_files.
Standard version without changed code does not.

It does not appear to.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • [X ] Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • [X ] My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • [ X] I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@arnova
Copy link
Member

arnova commented Mar 13, 2020

Looks good to me. Please remove the merge commit from this PR.

@snaunton
Copy link
Contributor Author

Have removed merge commit.

@lrusak lrusak added this to the Matrix 19.0-alpha 1 milestone Mar 17, 2020
@lrusak lrusak added Component: Video Type: Improvement non-breaking change which improves existing functionality v19 Matrix labels Mar 17, 2020
@arnova
Copy link
Member

arnova commented Mar 17, 2020

jenkins build this please

@arnova arnova merged commit 0b45f85 into xbmc:master Apr 12, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Apr 14, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Apr 16, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
Allow internetstream video sources in a LAN to look for exernal subtitle files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video Type: Improvement non-breaking change which improves existing functionality v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants