Skip to content

always allow gui playback info #1761

Closed
wants to merge 4 commits into from

2 participants

@elupus
Team Kodi member
elupus commented Nov 10, 2012

This series avoids the limit on gui infolabels based on if we are playing music or video, or any at all. It is partly a prep for the UPNP player. But it also should simplify the fixes for not loosing gui overlays while switching channels in pvr.

@jmarshallnz jmarshallnz commented on the diff Nov 10, 2012
xbmc/GUIInfoManager.cpp
@@ -3439,7 +3473,7 @@ CStdString CGUIInfoManager::GetPlaylistLabel(int item) const
CStdString CGUIInfoManager::GetMusicLabel(int item)
{
- if (!g_application.IsPlayingAudio() || !m_currentFile->HasMusicInfoTag()) return "";
+ if (!g_application.IsPlaying() || !m_currentFile->HasMusicInfoTag()) return "";
@jmarshallnz
Team Kodi member
jmarshallnz added a note Nov 10, 2012

I guess this changes behaviour in that musicplayer.* (except title) will return labels while video is playing. I don't think this change is needed though? (Same for the change on MUSICPLAYER_TITLE, GetVideoLabel() and VIDEOPLAYER_TITLE).

@elupus
Team Kodi member
elupus added a note Nov 10, 2012

Well.. for upnp player it is needed. It has no audio and no video, yet it has metadata for the playing item. This idea of blocking out metadata based on if it's playing audio is imho wrong.

But i do admit it could have adverse effects

@jmarshallnz
Team Kodi member
jmarshallnz added a note Nov 10, 2012

I agree completely - just not sure what the adverse effects may be. I suspect nothing, but not really sure. I doubt skins are using IsEmpty(MusicPlayer.Foo) for determining whether to show VideoPlayer.bar for example.

I'd be tempted to make the change anyway - ideally MusicPlayer.* should be dropped completely. I'd also drop the IsPlaying(Audio|Video)() checks from (Music|Video)Player.Title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@elupus
Team Kodi member
elupus commented Nov 11, 2012

I would prefer to get this in for Frodo btw, since it prepares skins for the upnp player stuff.

@elupus
Team Kodi member
elupus commented Nov 12, 2012

For frodo only the new info label is added. The rest will be merged with the upnp player when that goes in.

@elupus elupus closed this Nov 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.