bluray iso playback selection dialog #1764

Merged
merged 4 commits into from Nov 15, 2012

Projects

None yet

2 participants

@elupus
Member
elupus commented Nov 11, 2012

This should resolve the discrepancy between how .iso and bluray folders behaved when you startup playback. Previously starting index.bdmv would show a selection dialog to select what to play, but starting a .iso would always start longest track.

Now it should display selection for iso images as well

@elupus
Member
elupus commented Nov 11, 2012

While it is a fix for inconsistant behaviour for blurays. I couldn't really decide if it is frodo worthy. I'll put it as post frodo for now.

@ghost
ghost commented Nov 12, 2012

how about you pop in the first 3 and leave 4 for post.

@elupus
Member
elupus commented Nov 12, 2012

There was some parts in 4 that didn't belong there. (same fix in bluray input stream for not trying to guess path). It probably does make sense to push 1 through 3 in for frodo yea.

It's bug fixes for weird usage of urls. The last one is obviously a bit different.

@elupus
Member
elupus commented Nov 13, 2012

So i've dropped the ability to browse into bluray and kept the cleanup for stupid path usage. Then i added a fix for playback selection on a .iso/.img file by looking for a bluray inside on request.

This should resolve the discrepancy that existed between bluray image files and folders.

@elupus
Member
elupus commented Nov 15, 2012

@cptspiff so you skipped this one?

@elupus elupus merged commit bd0e2f5 into xbmc:master Nov 15, 2012
@Memphiz
Member

This commit might have broken DVD disc Playback on OSX in some situations. I can't reproduce but got 2 logs from a user (my testdvds all are playing well).

  1. log from a latest nightly which failed to play:
    http://xbmclogs.com/show.php?id=16082
  2. log from yesterdays master with this commit reverted which played:
    http://xbmclogs.com/show.php?id=16040

@elupus any idea what it might be?
edit: updated first link with a log from latest nightly and using the same DVD.

Member
Member

Nevermind.. You updated the post. But i see what is going on. The iso9660:// uri is somewhat invalid. The first element of it is not a hostname it's oddly the first path item. if the uri was made up iso9660:/// instead it probably works. I wonder what constructs the invalid URI.

Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment