Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t… #17760

Merged
merged 1 commit into from May 4, 2020

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Apr 26, 2020

CGUIDialogKaiToast now only closes the dialog if the whole toast text was displayed at least once.

Fixes #17441

No idea who could do a code review as guilib and dialogs code seems to be orphaned.

@MilhouseVH maybe you can add this PR to your testbuilds and if nobody complains for let's say a week we gonna merge this.

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: GUI engine v19 Matrix labels Apr 26, 2020
@ksooo ksooo added this to the Matrix 19.0-alpha 1 milestone Apr 26, 2020
@howie-f
Copy link
Contributor

howie-f commented Apr 26, 2020

cannot say much to the code, but the 1st appearing message...

screenshot002

is instantly overridden by the 2nd...

screenshot004

which stays until the message scrolled to the end

@ksooo
Copy link
Member Author

ksooo commented Apr 26, 2020

@howie-f thanks for the feedback. I will have a look.

but the 1st appearing message is instantly overridden by the 2nd...

Not caused by my PR, this has been like this before the PR. Needs fixing, nevertheless.

which stays until the message scrolled to the end

This is what my PR is intended to do.

@ksooo
Copy link
Member Author

ksooo commented Apr 26, 2020

@howie-f force-pushed an update. Could you retest, please?

@howie-f
Copy link
Contributor

howie-f commented Apr 26, 2020

@ksooo now the 1st is scrolling to the end like it should, the 2nd then pops up for 0,01 nanoseconds and is unreadable
next check tomorrow if you like :)

@MilhouseVH
Copy link
Contributor

@MilhouseVH maybe you can add this PR to your testbuilds and if nobody complains for let's say a week we gonna merge this.

Yes, however only once the issues identified by @howie-f are resolved!

@ksooo
Copy link
Member Author

ksooo commented Apr 27, 2020

@howie-f another force-pushed try. I think now we have it. Could you please retest?

@howie-f
Copy link
Contributor

howie-f commented Apr 27, 2020

@ksooo yes, perfect 👍

@ksooo
Copy link
Member Author

ksooo commented Apr 27, 2020

@MilhouseVH seems to work now.

@MilhouseVH
Copy link
Contributor

Ok, will include in #0427.

…he whole toast text was displayed at least once.
@ksooo
Copy link
Member Author

ksooo commented May 4, 2020

No negative feedback from Milhouse build testers. Merging...

@ksooo ksooo merged commit 1e22138 into xbmc:master May 4, 2020
@ksooo ksooo deleted the fix-toast-messages branch May 4, 2020 17:31
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toast messages are too short
3 participants