New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t… #17760
Conversation
@howie-f thanks for the feedback. I will have a look.
Not caused by my PR, this has been like this before the PR. Needs fixing, nevertheless.
This is what my PR is intended to do. |
cdabb44
to
37207e3
Compare
@howie-f force-pushed an update. Could you retest, please? |
@ksooo now the 1st is scrolling to the end like it should, the 2nd then pops up for 0,01 nanoseconds and is unreadable |
Yes, however only once the issues identified by @howie-f are resolved! |
37207e3
to
cea4932
Compare
@howie-f another force-pushed try. I think now we have it. Could you please retest? |
@ksooo yes, perfect 👍 |
@MilhouseVH seems to work now. |
Ok, will include in |
…he whole toast text was displayed at least once.
No negative feedback from Milhouse build testers. Merging... |
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
[dialogs][guillib] CGUIDialogKaiToast now only closes the dialog if t…
CGUIDialogKaiToast now only closes the dialog if the whole toast text was displayed at least once.
Fixes #17441
No idea who could do a code review as guilib and dialogs code seems to be orphaned.
@MilhouseVH maybe you can add this PR to your testbuilds and if nobody complains for let's say a week we gonna merge this.