FIX: [droid] Do not define XBMC_TEMP, thus moving temp to user folder, thus external storage if avail #1805

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Owner

koying commented Nov 16, 2012

Main goal is to move xbmc.log to user folder, so that it is accessible.

Still a FIX, IMO, because:

  1. temp, i.e. ever-changing files, should not be put on internal flash if possible.
  2. this aligns droid with the other 'nix platforms

theuni was assigned Nov 16, 2012

Owner

Montellese commented Nov 17, 2012

IIRC initially I had it setup to have the temporary files on the external storage if available but someone changed it (due to speed reasons?).

Owner

koying commented Nov 17, 2012

Yeah, should probably be tested on a device with a "real" sdcard (on Nexus7 is just a link to another flash partition).
OTOH, "degrading" (as in x writes before bad sector) the internal flash to write some log/temp files is something I'm not at ease with... AFAIK, it is not what the droid cache is made for.

Member

da-anda commented Dec 6, 2012

I could test on my phone having a real SD card (running Android 2.3.5 or so) - but I would need an apk as I can't build for Android.

Owner

koying commented Jan 31, 2013

I had an issue with smb with this PR on. Don't know why but it isn't worth spending time on this

koying closed this Jan 31, 2013

Member

theuni commented Mar 9, 2013

Hmm, just saw this PR, never noticed it before. Sorry for that.

@koying Likely your issue was that android refuses to allow unix sockets on removable media.

Owner

koying commented Mar 9, 2013

Ah, ok. Thanks.
We should still find something regarding logs because, on JB, even an adb pull is not permitted if you are not root.
So the one and only way to get logs there is via the uploader.

Member

theuni commented Mar 9, 2013

Yep, we need to break log out into its own configurable path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment