Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Estuary] fix log errors #18170

Merged
merged 1 commit into from Jul 16, 2020
Merged

[Estuary] fix log errors #18170

merged 1 commit into from Jul 16, 2020

Conversation

ronie
Copy link
Member

@ronie ronie commented Jul 16, 2020

one of the visible conditions in #18141 wasn't formatted properly, causing errors to appear in the logifile.

thx @ksooo for the heads-up! (#18141 (review))

@DaveTBlake this one should be suitable for alpha1

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@ronie ronie added Type: Fix non-breaking change which fixes an issue Component: Skin v19 Matrix labels Jul 16, 2020
@ronie ronie added this to the Matrix 19.0-alpha 1 milestone Jul 16, 2020
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@DaveTBlake DaveTBlake merged commit cfcb920 into xbmc:master Jul 16, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jul 16, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Jul 16, 2020
@ronie ronie deleted the fix-PR18141 branch July 29, 2020 00:06
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Skin Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants