settings: update videoscreen.screenmode value when updating to Frodo #1830

Merged
merged 1 commit into from Nov 23, 2012

Conversation

Projects
None yet
4 participants
@Montellese
Owner

Montellese commented Nov 22, 2012

Found another setting that doesn't update properly from Eden to Frodo: videoscreen.screenmode. As it is used for screen and resolution selection we should try to update the old (Eden) value. All that has changed in Frodo is that we add a "p" or an "i" at the end to indicate progressive or interlaced. So it's pretty easy to detect the update because the length of the value of videoscreen.screenmode goes from 20 to 21. This simply adds a "p" at the end to make the value compatible with Frodo (otherwise it completely falls back to RES_DESKTOP). Another option would be to change the implementation of CGUISettings::GetResFromString() to be able to handle values with or without the progressive/interlaced indicator.

Let me know which approach you prefer. I don't think there's a way to actually make an educated guess about progressive or interlaced at the time we load the GUI settings because the windowing system is initialized later so we can't just use whatever e.g. RES_DESKTOP uses.

@jmarshallnz

This comment has been minimized.

Show comment Hide comment
@jmarshallnz

jmarshallnz Nov 22, 2012

Member

Looks OK to me.

Member

jmarshallnz commented Nov 22, 2012

Looks OK to me.

@Memphiz

This comment has been minimized.

Show comment Hide comment
@Memphiz

Memphiz Nov 23, 2012

Owner

Why is screenmode always 20 chars long in eden? Isn't screenmode the 1920x1080@50 thingy?

Owner

Memphiz commented Nov 23, 2012

Why is screenmode always 20 chars long in eden? Isn't screenmode the 1920x1080@50 thingy?

@Montellese

This comment has been minimized.

Show comment Hide comment
@Montellese

Montellese Nov 23, 2012

Owner

It's a concatenated string containing

Owner

Montellese commented Nov 23, 2012

It's a concatenated string containing

@Memphiz

This comment has been minimized.

Show comment Hide comment
@Memphiz

Memphiz Nov 23, 2012

Owner

Thx for the clarification :)

Owner

Memphiz commented Nov 23, 2012

Thx for the clarification :)

@davilla

This comment has been minimized.

Show comment Hide comment
@davilla

davilla Nov 23, 2012

Contributor

looks good as it, +1 inject.

Contributor

davilla commented Nov 23, 2012

looks good as it, +1 inject.

Montellese added a commit that referenced this pull request Nov 23, 2012

Merge pull request #1830 from Montellese/screenmode_settings_update
settings: update videoscreen.screenmode value when updating to Frodo

@Montellese Montellese merged commit 914e708 into xbmc:master Nov 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment