pvr: Fixed playback of recordings without stream url #1837

Merged
merged 1 commit into from Dec 1, 2012

Conversation

Projects
None yet
2 participants
Member

fetzerch commented Nov 23, 2012

Currently, the playback of recordings via the context menu is broken for recordings without a stream url.
This PR makes sure that the playback of all recordings is triggered by CGUIWindowPVRCommon::PlayRecording and makes sure that recordings also play from the context menu.

Right now the playback is started by a later call to OnSelect in CGUIMediaWindow::OnMessage. Which does only work when clicking/selecting a recording directly, but not via the context menu.

Let me know if this fix is appropriate.
Thanks,
Christian

pvr: Fixed playback of recordings without stream url
Recordings without stream urls were not played directly in
CGUIWindowPVRCommon::PlayRecording but later through a call
to OnSelect in CGUIMediaWindow::OnMessage.
Unfortunately this only works when clicking/selecting on
a recording but not when the playback is started over
the context menu.
Member

opdenkamp commented Nov 26, 2012

looks valid. i'll check it properly asap

@ghost ghost assigned opdenkamp Nov 26, 2012

opdenkamp pushed a commit that referenced this pull request Dec 1, 2012

Merge pull request #1837 from fetzerch/bugfix-playrecording
pvr: Fixed playback of recordings without stream url

@opdenkamp opdenkamp merged commit 2bce332 into xbmc:master Dec 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment