Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

pvr: Fixed playback of recordings without stream url #1837

Merged
merged 1 commit into from

2 participants

@fetzerch

Currently, the playback of recordings via the context menu is broken for recordings without a stream url.
This PR makes sure that the playback of all recordings is triggered by CGUIWindowPVRCommon::PlayRecording and makes sure that recordings also play from the context menu.

Right now the playback is started by a later call to OnSelect in CGUIMediaWindow::OnMessage. Which does only work when clicking/selecting a recording directly, but not via the context menu.

Let me know if this fix is appropriate.
Thanks,
Christian

@fetzerch fetzerch pvr: Fixed playback of recordings without stream url
Recordings without stream urls were not played directly in
CGUIWindowPVRCommon::PlayRecording but later through a call
to OnSelect in CGUIMediaWindow::OnMessage.
Unfortunately this only works when clicking/selecting on
a recording but not when the playback is started over
the context menu.
78c021e
@opdenkamp
Collaborator

looks valid. i'll check it properly asap

@opdenkamp opdenkamp was assigned
@opdenkamp opdenkamp merged commit 2bce332 into xbmc:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 23, 2012
  1. @fetzerch

    pvr: Fixed playback of recordings without stream url

    fetzerch authored
    Recordings without stream urls were not played directly in
    CGUIWindowPVRCommon::PlayRecording but later through a call
    to OnSelect in CGUIMediaWindow::OnMessage.
    Unfortunately this only works when clicking/selecting on
    a recording but not when the playback is started over
    the context menu.
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 1 deletion.
  1. +4 −1 xbmc/pvr/windows/GUIWindowPVRCommon.cpp
View
5 xbmc/pvr/windows/GUIWindowPVRCommon.cpp
@@ -617,7 +617,10 @@ bool CGUIWindowPVRCommon::PlayRecording(CFileItem *item, bool bPlayMinimized /*
CStdString stream = item->GetPVRRecordingInfoTag()->m_strStreamURL;
if (stream == "")
- return false;
+ {
+ CApplicationMessenger::Get().PlayFile(*item, false);
+ return true;
+ }
/* Isolate the folder from the filename */
size_t found = stream.find_last_of("/");
Something went wrong with that request. Please try again.