Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

remove broken Itunes visualization #1841

Merged
merged 1 commit into from Nov 24, 2012

Conversation

Projects
None yet
6 participants
Owner

ronie commented Nov 24, 2012

this one has been dead in the water for over two years and is starting to smell
http://forum.xbmc.org/showthread.php?tid=77990

the first commit skips building&installing of the itunes visualization.

the second commit removes the broken code.
i'm not sure if we want to keep it around, just in case someone ever want to fix it

@ghost ghost assigned davilla Nov 24, 2012

Contributor

amet commented Nov 24, 2012

I would merge 2 commits :)

Contributor

davilla commented Nov 24, 2012

merge into one commit then inject.

ronie added a commit that referenced this pull request Nov 24, 2012

Merge pull request #1841 from ronie/itunes-visualization
remove broken Itunes visualization

@ronie ronie merged commit c58514e into xbmc:master Nov 24, 2012

Owner

MartijnKaijser commented Nov 24, 2012

@alanwww1
Please remove language files too from transifex

Member

alanwww1 commented Nov 24, 2012

@MartijnKaijser
Removed from Transifex as well.
Thanks for the note !

@ronie
Well, I'm a total git and XBMC newb, but I'm pretty sure this change broke the Raspberry Pi build. With a fresh clone, and following the build instructions at http://www.raspbmc.com/wiki/technical/building-xbmc/, I get the following build error:

config.status: error: cannot find input file:xbmc/visualizations/iTunes/Makefile.in'
make: *** [configure] Error 1
make: Leaving directory /home/build/xbmc/tools/rbp/depends/xbmc' make: *** No rule to make targetxbmc/visualizations/iTunes/Makefile.in', needed by Makefile'. Stop.

I notice that xbmc/visualizations/iTunes/Makefile is referenced in xbmc/configure.in and removing this line (2379) lets my build proceed.

If there is any more information I can provide, please do not hesitate to ask.

Owner

ronie commented Nov 24, 2012

thanx!
should be fixed now

Confirmed. Thanks for the quick turnaround!

@ronie ronie deleted the ronie:itunes-visualization branch Feb 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment