Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use software decoder, as there is no known hardware decoder for 12bit h265 #18926

Merged
merged 1 commit into from Dec 13, 2020

Conversation

razzeee
Copy link
Member

@razzeee razzeee commented Dec 11, 2020

Description

I found a file that's only playable via software decoding on android.

Motivation and Context

This should enable Kodi to fallback to software decoding if it get's handed such a file.

How Has This Been Tested?

I will test this, as soon as jenkins produces a build.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@razzeee
Copy link
Member Author

razzeee commented Dec 11, 2020

Tested the build, seems to work fine

@lrusak lrusak changed the title Use software decoder, as there is no known hardware decoder for 10bit h265 Use software decoder, as there is no known hardware decoder for 12bit h265 Dec 11, 2020
@lrusak
Copy link
Contributor

lrusak commented Dec 11, 2020

I edited the title as 10bit hevc decoders do exists (not sure about on android) but this is really for >10bit as FF_PROFILE_HEVC_REXT is for hevc range extensions which are defined as

The Range Extensions (RExt) of the High Efficiency
Video Coding (HEVC) standard have recently been approved
by both ITU-T and ISO/IEC. This set of extensions targets
video coding applications in areas including content acquisition,
postproduction, contribution, distribution, archiving, medical
imaging, still imaging, and screen content. In addition to the
functionality of HEVC Version 1, RExt provide support for
monochrome, 4:2:2, and 4:4:4 chroma sampling formats as well
as increased sample bit depths beyond 10 bits per sample.
...

ref: https://ieeexplore.ieee.org/stamp/stamp.jsp?arnumber=7265015

@lrusak lrusak added Component: Video Platform: Android Type: Fix non-breaking change which fixes an issue v19 Matrix labels Dec 11, 2020
@lrusak lrusak added this to the Matrix 19.0-RC1 milestone Dec 11, 2020
@razzeee razzeee force-pushed the h265-10bit-software-fallthrough branch from 72e8dbc to 04666bd Compare December 12, 2020 13:35
@razzeee
Copy link
Member Author

razzeee commented Dec 12, 2020

Aligned the commit message

@fritsch fritsch merged commit c6acd4d into xbmc:master Dec 13, 2020
@fritsch fritsch self-requested a review December 13, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants