Skip to content

extend ClearSkinString() range #1908

Closed
wants to merge 1 commit into from

4 participants

@phil65
Team Kodi member
phil65 commented Dec 8, 2012

atm when switching between skins some strange localization issues can occur where labels from the previous skin can take over labels of the skin which got loaded.
i looked through some skins and checked in which skin id range they are using.
xperience and nox go up to 45xxx so i took 46000 as the upper range limit.

if this has any downside i´d also happily adjust the labels inside the skin to use only 31xxx. this would be the quicker way though^^

@MartijnKaijser
Team Kodi member

@jmarshallnz
Should this go into Frodo?

@ronie
Team Kodi member
ronie commented Dec 26, 2012

-1 on getting this in.

imo skins should just stick to using the string range that's reserved for them.

@phil65
Team Kodi member
phil65 commented Dec 26, 2012

would be ok with that, just tell me so i can get it fixed. i just did not know that there is some reserved space which should be used by skins, i (and problably the others too) thaught everything above 31000 would be ok. if this doesn´t get pulled it would still be nice if you would extend it to 32999 though.
does it make a difference from a performance perspective if we clear a bigger range?

@ronie
Team Kodi member
ronie commented Dec 26, 2012

i can't remember how i found out about it, probably by checking the default xbmc language file.

i'm not sure why you would like to extend the range to 32999?
does your skin need more than 1000 strings?

using 32000-32999 in a skin is no option anyway as those are reserved for scripts.

@phil65
Team Kodi member
phil65 commented Dec 26, 2012

we´re at approx. 600, extending it would make it easier to pull all the strings outside of the range inside it with a bit of regex. without i have to search and replace every single label outside the range manually to fill up the empty spaces + who knows if we will hit 1000 in some years^^
since 32000 onwards is already used i think i have to go the hard route and invest an hour in search and replacing. not a big deal. will do that then if i find some time.

@ronie ronie closed this Jan 3, 2013
@alanwww1
Team Kodi member
alanwww1 commented Jan 3, 2013

@phil65
Just FYI
Please note that if you change the id number of the string, it will appear as a new translatable string in Transifex. That is because the id is treated as a context for the string. This is how we ensure that we can have the same English string in different contexts.

Just a note.

@phil65
Team Kodi member
phil65 commented Jan 3, 2013

yes thx, knew that already. that´s why i will shift that change a bit to after initial release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.