Add nfs support - closes #3358 #192

Merged
merged 9 commits into from Jun 18, 2011

Conversation

Projects
None yet
3 participants
@Memphiz
Member

Memphiz commented Jun 11, 2011

Hi folks,

like title says this would add nfs support for linux, osx and ios. The libnfs dependency is already prepared in master and will be built automagically for osx/ios once the darwin build sys is activated. Linux devs should build lib/libnfs and install it before running configure for getting it pickup the nfs support.

Not much to say about it. putting on his helmet for accepting blames

PS: sorry for the WIN32 guys. I did one try to port this over to win32 - but the libnfs rpc stuff broke my neck.

@dbrobins

This comment has been minimized.

Show comment
Hide comment
@dbrobins

dbrobins Jun 14, 2011

Excuse what may seem an ignorant question, but why add NFS support through a library rather than having the user mount the remote share using their mechanism of choice and treat it as local? Permissions and access?

Excuse what may seem an ignorant question, but why add NFS support through a library rather than having the user mount the remote share using their mechanism of choice and treat it as local? Permissions and access?

@Memphiz

This comment has been minimized.

Show comment
Hide comment
@Memphiz

Memphiz Jun 14, 2011

Member

There are plattforms which can't mount (ios).

Member

Memphiz commented Jun 14, 2011

There are plattforms which can't mount (ios).

@sahlberg

This comment has been minimized.

Show comment
Hide comment
@sahlberg

sahlberg Jun 15, 2011

Why not mount on the underlying host system?

Several reasons, some better than others :-)
1, On some platforms you cant mount at all.
2, Sometimes you might want to not expose the NFS share outside of the application and not make it visible to the underlying host. this allows the "mount" to be private to the application.
3, Only root can mount a share on the host. This allows non-root users to access the data on the NFS share.
4, When/if ported to Win32, this allows win32 users to access nfs shares out-of-the-box without the hassle of dealing with SFU.

Why not mount on the underlying host system?

Several reasons, some better than others :-)
1, On some platforms you cant mount at all.
2, Sometimes you might want to not expose the NFS share outside of the application and not make it visible to the underlying host. this allows the "mount" to be private to the application.
3, Only root can mount a share on the host. This allows non-root users to access the data on the NFS share.
4, When/if ported to Win32, this allows win32 users to access nfs shares out-of-the-box without the hassle of dealing with SFU.

@Memphiz

This comment has been minimized.

Show comment
Hide comment
@Memphiz

Memphiz Jun 16, 2011

Member

If nobody of the linux devs spotted any blocker for this, i would like to rebase once more and hit the green button in 2 days.

Member

Memphiz commented Jun 16, 2011

If nobody of the linux devs spotted any blocker for this, i would like to rebase once more and hit the green button in 2 days.

Memphiz added a commit that referenced this pull request Jun 18, 2011

Merge pull request #192 from Memphiz/libnfs5
Add nfs support - closes #3358 - needs libnfs at compiletime (osx/ios will build it when switched to darwin-depends - linux needs to make lib/libnfs and make install)

@Memphiz Memphiz merged commit 5db9543 into xbmc:master Jun 18, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment