[LinuxRendererGLES] - Don't let RENDER_BYPASS clear out the whole screen #1920

Merged
merged 1 commit into from Dec 11, 2012

Projects

None yet

4 participants

@mikrohard
Contributor

Currently RENDER_BYPASS clears out the whole screen which results in an ugly view when video isn't in fullscreen (e.g. pvr window in confluence).

This commit uses the glScissor function to clear out the video rect only.

Example before: https://dl.dropbox.com/u/8261657/bypass_before.png
Example after: https://dl.dropbox.com/u/8261657/bypass_after.png

Tested on linux (pivos buildroot) and android (amlplayer) with different resolutions.

These are my first lines of code in OpenGL... there can be very well a better solution for this. But I didn't see any problems (not with performance or anything else).

@huceke
Contributor
huceke commented Dec 11, 2012

I'll also test it in the RaspberryPI.

@Memphiz
Member
Memphiz commented Dec 11, 2012

nice - @davilla - thats what i ment some days ago :D

@davilla
Contributor
davilla commented Dec 11, 2012

nice

@huceke
Contributor
huceke commented Dec 11, 2012

You should iWidth and iHeight otherwise it doesn't work with clamped gui rendering.

@mikrohard
Contributor

Ok... will fix right away...

@huceke
Contributor
huceke commented Dec 11, 2012

Looks ok from my side. @davilla @theuni would be nice for frodo ;)

@davilla davilla merged commit d72b23b into xbmc:master Dec 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment