Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fixed: If player wasn't playing at normal speed while selecting a new it... #1928

Merged
merged 1 commit into from Dec 13, 2012

Conversation

Projects
None yet
2 participants
Member

arnova commented Dec 13, 2012

...em, the play speed would not properly be reset to normal.

arnova fixed: If player wasn't playing at normal speed while selecting a new…
… item, the play speed would not properly be reset to normal
6dd90a0

Ack the removal of m_iPlaySpeed, it borks what happens inside SetPlaySpeed.
Nak the move of it below SetPlaySpeed, SetPlaySpeed should be already be setting m_iPlaySpeed if it's different than what was passed in. Why is this needed ? Did SetPlaySpeed set it wrong ? Seems that one should just remove the m_iPlaySpeed entirely.

Owner

arnova replied Dec 13, 2012

My reasoning was that SetPlaySpeed() will only update m_iPlaySpeed when there already is a player playing (m_player != NULL). I suspected that may cause problems. The only way to workaround that is having SetPlaySpeed() ALWAYS update m_iPlaySpeed regardless of the state of m_player, but I'm not entirely sure whether doing that is 100% safe?

@davilla davilla added a commit that referenced this pull request Dec 13, 2012

@davilla davilla Merge pull request #1928 from arnova/paplayer_seek_fix
fixed: If player wasn't playing at normal speed while selecting a new it...
dae8f6e

@davilla davilla merged commit dae8f6e into xbmc:master Dec 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment