decouple rendering and window closing, fixes #13650 #1938

merged 1 commit into from Dec 15, 2012


None yet

2 participants

pieh commented Dec 15, 2012

We can stuck on window closing if control report empty dirty region (f.e. label control without text or control group without child controls) because we rely on CGUIWindow::Render() being called to finish window closing (which won't be called as empty dirty regions are discarded in dirty region tracker).

This decouples rendereing and window closing by adding new AfterRender() methods that will be called each frame (regardless of dirty region state) that will handle window closing.

More details in

@pieh pieh decouple rendering and window closing, add AfterRender method (that w…
…ill be called each frame even if we actually didn't render anything) and move window closing logic there

fixes #13650

Looks good.

@jmarshallnz jmarshallnz merged commit a17906b into xbmc:master Dec 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment