Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
videodb: retrieve streamdetails while retrieving other details which require extra SQL queries #1945
Currently we don't retrieve streamdetails when e.g. retrieving the cast for movies or tags for musicvideos even though all those actions require extra SQL queries. That means that we have to manually call CVideoDatabase::GetStreamDetails wherever we call GetMovieInfo/GetEpisodeInfo/GetMusicVideoInfo to get all the details of a video. This leads to a lot of more or less duplicate code and several issues in JSON-RPC where streamdetails are reported empty even though there are streamdetails for a specific video (Martijn has discovered such an issue a few days ago, see http://trac.xbmc.org/ticket/13749) which makes the API or rather the values returned by the API inconsistent.
Probably also fixes http://trac.xbmc.org/ticket/13720 (not tested yet).
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Yeah still not working for Files.GetDirectory because it goes through CDirectory::GetDirectory and we don't retrieve these details for list items in general. Will have to add some extra code nonetheless (which I'd really prefer to avoid but all the logic required is all over the place).