Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

[vaapi] Fix crash while playing mpeg2 files #1954

Merged
1 commit merged into from Apr 6, 2013

Conversation

Projects
None yet
4 participants
Contributor

anuj-m commented Dec 18, 2012

This fixes the crash while playing MPEG2 files with sequence display extension. Files with this extension in the header cause the decoder to re-init resulting in a crash.

Ensure that the decoder is init once only.
This fixes the crash while playing MPEG2 files with sequence display extension.

@ghost ghost assigned elupus Dec 18, 2012

@ghost ghost pushed a commit that referenced this pull request Apr 6, 2013

Merge pull request #1954 from anuj-m/master
[vaapi] Fix crash while playing mpeg2 files

@ghost ghost merged commit 53a3ddb into xbmc:master Apr 6, 2013

Member

FernetMenta commented on 6d637d4 Dec 2, 2013

This cases ugly malloc/free segfaults all over the place when playing vc-1. Was really hard to track down. Why was this needed?

Member

fritsch replied Dec 2, 2013

Verified on my intel rigs. VC-1 does not corrupt the heap anymore. We cannot just set it to NULL in case of VC-1 it might still be in use. Why not handle it as the others do? if not NULL return *cur;

Edit: Sorry, just remove it. It is handled in the Decoder itself, just create a new one.

Member

elupus replied Nov 18, 2014

I need to add something like this again, but in a more complete way: elupus/xbmc@740b28a

Can we reproduce the issues?

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment