Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

[add] visualization.fishbmc addon #1999

Merged
merged 1 commit into from

5 participants

@maysl

sorry, corrupted the original pull request found here: #1060

@ronie
Collaborator

@maysl mind squashing things into a single commit?
would like to get this in now master is open for business again.

oh, get rid of the Merge branch 'master' commit btw. ;-)

@maysl

No, a different stupidity ;)
I'll throw out the merge commit.

@maysl maysl closed this
@alanwww1
Collaborator

@maysl
Thanks for the work.
I'll convert the strings file to po format and put it up to Transifex for translation, later after merge.
Cheers, Attila

@maysl maysl reopened this
@ronie
Collaborator

builds and runs fine on linux 64 bit

@maysl

  • which platforms are supported? we need a dev signoff on each of those
  • if you could include an icon.png as well. doesn't have to be anything fancy, just a 256x256 screenshot would be good enough
  • in case you missed my previous comment, please squash everything into a single commit
@alanwww1
Collaborator

I volunteer to test it on Windows, if it is supported.
From the addon.xml, I only see Linux and OSX. @maysl can you confirm ?
Thanks

@amet

at some point I touched this for OSX, worked fine then

@MartijnKaijser

@alanwww1
I tested on windows and it doesn't show up initially so it probably needs more work.
From previous PR i read:
"Builds and works on Linux and OSX, DX port needs developer, GLES port in evaluation"

@alanwww1
Collaborator

Ok. So no test for Win at the moment.
So after the squash I think it can go in.

@maysl maysl closed this
@maysl maysl reopened this
@maysl
  • I can confirm the viz works on Linux 32/64 and OSX.
  • Windows is not supported. Porting would be a trivial joke for anyone who knows how to draw a textured quad in DX. I just don't have a Windows machine to develop on.
  • An icon.png is included. Is it in the wrong place? (/addons/visualization.fishbmc/icon.png)
  • Squash done.
@ronie ronie merged commit 4da3b0c into from
@ronie
Collaborator

thanx @maysl

it was about time we got some fresh fish in xbmc ;-)

@tru tru referenced this pull request from a commit in plexinc/plex-home-theater-public
@tru tru Switch to Now Playing when playing the first music track
Fixes #1999
ac89cf5
@tru tru referenced this pull request from a commit in RasPlex/plex-home-theatre
@tru tru Switch to Now Playing when playing the first music track
Fixes #1999
e72522f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 31, 2013
  1. @maysl

    [add] visualization.fishbmc

    Marcel Ebmer authored maysl committed
Something went wrong with that request. Please try again.