Skip to content
This repository

[add] visualization.fishbmc addon #1999

Merged
merged 1 commit into from over 1 year ago

5 participants

Marcel Ebmer ronie alanwww1 (Attila) Zeljko Ametovic Martijn Kaijser
Marcel Ebmer

sorry, corrupted the original pull request found here: #1060

ronie
Collaborator

@maysl mind squashing things into a single commit?
would like to get this in now master is open for business again.

oh, get rid of the Merge branch 'master' commit btw. ;-)

Marcel Ebmer

No, a different stupidity ;)
I'll throw out the merge commit.

Marcel Ebmer maysl closed this
alanwww1 (Attila)
Collaborator

@maysl
Thanks for the work.
I'll convert the strings file to po format and put it up to Transifex for translation, later after merge.
Cheers, Attila

Marcel Ebmer maysl reopened this
ronie
Collaborator

builds and runs fine on linux 64 bit

@maysl

  • which platforms are supported? we need a dev signoff on each of those
  • if you could include an icon.png as well. doesn't have to be anything fancy, just a 256x256 screenshot would be good enough
  • in case you missed my previous comment, please squash everything into a single commit
alanwww1 (Attila)
Collaborator

I volunteer to test it on Windows, if it is supported.
From the addon.xml, I only see Linux and OSX. @maysl can you confirm ?
Thanks

Zeljko Ametovic
Collaborator

at some point I touched this for OSX, worked fine then

Martijn Kaijser

@alanwww1
I tested on windows and it doesn't show up initially so it probably needs more work.
From previous PR i read:
"Builds and works on Linux and OSX, DX port needs developer, GLES port in evaluation"

alanwww1 (Attila)
Collaborator

Ok. So no test for Win at the moment.
So after the squash I think it can go in.

Marcel Ebmer maysl closed this
Marcel Ebmer maysl reopened this
Marcel Ebmer
  • I can confirm the viz works on Linux 32/64 and OSX.
  • Windows is not supported. Porting would be a trivial joke for anyone who knows how to draw a textured quad in DX. I just don't have a Windows machine to develop on.
  • An icon.png is included. Is it in the wrong place? (/addons/visualization.fishbmc/icon.png)
  • Squash done.
ronie ronie merged commit 4da3b0c into from
ronie ronie closed this
ronie
Collaborator

thanx @maysl

it was about time we got some fresh fish in xbmc ;-)

Tobias Hieta tru referenced this pull request from a commit in plexinc/plex-home-theater-public
Tobias Hieta tru Switch to Now Playing when playing the first music track
Fixes #1999
ac89cf5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 2 authors.

Jan 31, 2013
Marcel Ebmer [add] visualization.fishbmc 77d450f
Something went wrong with that request. Please try again.