[add] visualization.fishbmc addon #1999

Merged
merged 1 commit into from Jan 31, 2013

Conversation

Projects
None yet
5 participants
@maysl

maysl commented Dec 28, 2012

sorry, corrupted the original pull request found here: #1060

@ronie

This comment has been minimized.

Show comment Hide comment
@ronie

ronie Jan 29, 2013

Member

@maysl mind squashing things into a single commit?
would like to get this in now master is open for business again.

oh, get rid of the Merge branch 'master' commit btw. ;-)

Member

ronie commented Jan 29, 2013

@maysl mind squashing things into a single commit?
would like to get this in now master is open for business again.

oh, get rid of the Merge branch 'master' commit btw. ;-)

@maysl

This comment has been minimized.

Show comment Hide comment
@maysl

maysl Jan 30, 2013

No, a different stupidity ;)
I'll throw out the merge commit.

maysl commented Jan 30, 2013

No, a different stupidity ;)
I'll throw out the merge commit.

@maysl maysl closed this Jan 30, 2013

@alanwww1

This comment has been minimized.

Show comment Hide comment
@alanwww1

alanwww1 Jan 30, 2013

Member

@maysl
Thanks for the work.
I'll convert the strings file to po format and put it up to Transifex for translation, later after merge.
Cheers, Attila

Member

alanwww1 commented Jan 30, 2013

@maysl
Thanks for the work.
I'll convert the strings file to po format and put it up to Transifex for translation, later after merge.
Cheers, Attila

@maysl maysl reopened this Jan 30, 2013

@ronie

This comment has been minimized.

Show comment Hide comment
@ronie

ronie Jan 30, 2013

Member

builds and runs fine on linux 64 bit

@maysl

  • which platforms are supported? we need a dev signoff on each of those
  • if you could include an icon.png as well. doesn't have to be anything fancy, just a 256x256 screenshot would be good enough
  • in case you missed my previous comment, please squash everything into a single commit
Member

ronie commented Jan 30, 2013

builds and runs fine on linux 64 bit

@maysl

  • which platforms are supported? we need a dev signoff on each of those
  • if you could include an icon.png as well. doesn't have to be anything fancy, just a 256x256 screenshot would be good enough
  • in case you missed my previous comment, please squash everything into a single commit
@alanwww1

This comment has been minimized.

Show comment Hide comment
@alanwww1

alanwww1 Jan 31, 2013

Member

I volunteer to test it on Windows, if it is supported.
From the addon.xml, I only see Linux and OSX. @maysl can you confirm ?
Thanks

Member

alanwww1 commented Jan 31, 2013

I volunteer to test it on Windows, if it is supported.
From the addon.xml, I only see Linux and OSX. @maysl can you confirm ?
Thanks

@amet

This comment has been minimized.

Show comment Hide comment
@amet

amet Jan 31, 2013

Contributor

at some point I touched this for OSX, worked fine then

Contributor

amet commented Jan 31, 2013

at some point I touched this for OSX, worked fine then

@MartijnKaijser

This comment has been minimized.

Show comment Hide comment
@MartijnKaijser

MartijnKaijser Jan 31, 2013

Member

@alanwww1
I tested on windows and it doesn't show up initially so it probably needs more work.
From previous PR i read:
"Builds and works on Linux and OSX, DX port needs developer, GLES port in evaluation"

Member

MartijnKaijser commented Jan 31, 2013

@alanwww1
I tested on windows and it doesn't show up initially so it probably needs more work.
From previous PR i read:
"Builds and works on Linux and OSX, DX port needs developer, GLES port in evaluation"

@alanwww1

This comment has been minimized.

Show comment Hide comment
@alanwww1

alanwww1 Jan 31, 2013

Member

Ok. So no test for Win at the moment.
So after the squash I think it can go in.

Member

alanwww1 commented Jan 31, 2013

Ok. So no test for Win at the moment.
So after the squash I think it can go in.

@maysl maysl closed this Jan 31, 2013

@maysl maysl reopened this Jan 31, 2013

@maysl

This comment has been minimized.

Show comment Hide comment
@maysl

maysl Jan 31, 2013

  • I can confirm the viz works on Linux 32/64 and OSX.
  • Windows is not supported. Porting would be a trivial joke for anyone who knows how to draw a textured quad in DX. I just don't have a Windows machine to develop on.
  • An icon.png is included. Is it in the wrong place? (/addons/visualization.fishbmc/icon.png)
  • Squash done.

maysl commented Jan 31, 2013

  • I can confirm the viz works on Linux 32/64 and OSX.
  • Windows is not supported. Porting would be a trivial joke for anyone who knows how to draw a textured quad in DX. I just don't have a Windows machine to develop on.
  • An icon.png is included. Is it in the wrong place? (/addons/visualization.fishbmc/icon.png)
  • Squash done.

ronie added a commit that referenced this pull request Jan 31, 2013

@ronie ronie merged commit 4da3b0c into xbmc:master Jan 31, 2013

@ronie

This comment has been minimized.

Show comment Hide comment
@ronie

ronie Jan 31, 2013

Member

thanx @maysl

it was about time we got some fresh fish in xbmc ;-)

Member

ronie commented Jan 31, 2013

thanx @maysl

it was about time we got some fresh fish in xbmc ;-)

tru added a commit to plexinc/plex-home-theater-public that referenced this pull request May 23, 2014

tru added a commit to RasPlex/plex-home-theatre that referenced this pull request Aug 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment