New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize 'loaded' flag in CScraper::Clone constructor. #200

Merged
merged 1 commit into from Jun 14, 2011

Conversation

Projects
None yet
2 participants
@dbrobins

dbrobins commented Jun 14, 2011

http://trac.xbmc.org/ticket/11637. I don't actually repro this but based on the call stack this looks to be the correct fix: a cloned CScraper is likely defaulting m_fLoaded to true (since it is not initialized), leading to a crash due to null XML tree pointers from the scraper not actually being loaded.

mkortstiege added a commit that referenced this pull request Jun 14, 2011

Merge pull request #200 from dbrobins/scraper-clone-fix
Initialize 'loaded' flag in CScraper::Clone constructor. (fixes #11637)

@mkortstiege mkortstiege merged commit c77775a into xbmc:master Jun 14, 2011

@mkortstiege

This comment has been minimized.

Show comment
Hide comment
@mkortstiege

mkortstiege Jun 14, 2011

Member

Thanks.

Member

mkortstiege commented Jun 14, 2011

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment