Show '..' items as we're supposed to in empty lists #2007

Merged
merged 2 commits into from Dec 30, 2012

Projects

None yet

4 participants

@jmarshallnz
Member

The code that added the '..' item when lists were empty was not kicking in for filtered lists, as we were adding it before filtering only if the list was empty.

Moving it afterwards means it works as intended.

This has the side-effect of removing an unneeded toast dialog that could annoy users, as well as automatically changing the directory back up a folder on empty lists when that may not have been what the user was wanting.

Fixes the issues on trac at #13662 and #13837.

@Montellese
Member

Well you know my opinion on the matter. If I disable "Show parent folder items" in the settings I do it because I don't want to see the ".." anywhere (which is why I added the jump-back logic). But I guess I'm the only one with that opinion.

@MartijnKaijser
Member

Agree with @Montellese
Also I think we discussed at devcon on getting rid of those dots altogether because we have the back button almost everywhere

@ronie
Member
ronie commented Dec 30, 2012

hmm.. doesn't work on my end.

i still get an empty list when i apply a filter that doesn't produce any results.
same issue when marking all as watched and toggling 'hide watched'.

@Montellese
Member

Toggling hide watched should work because that triggers a call to CGUIMediaWindow::Update() and the actual watched filtering is done in CGUIWindowVideoNav::OnFilterItems but filtering doesn't. So this logic would have to be duplicated and also placed in the filtering logic.

Jonathan Mar... added some commits Dec 30, 2012
Jonathan Marshall fixed: the auto-addition of '..' when the list is empty did not show …
…up on filtered lists
c906274
Jonathan Marshall remove unnecessary toast + parent folder of empty lists after filteri…
…ng - the '..' item is shown, so this won't be hit anyway
ede31b2
@jmarshallnz
Member

Updated to a version I bothered testing.

@Montellese this just fixes the previously broken behaviour - i.e. we've had this functionality since Eden at least, whether you like it or not :p I suggest post-Frodo if it bugs you heaps then change the "show parent items" to a tri-state (never, always, only for an empty list).

@ronie
Member
ronie commented Dec 30, 2012

yup, all working now.

@jmarshallnz jmarshallnz merged commit a1d90c1 into xbmc:master Dec 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment