Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

fix configure warnings when lame lib exists but not the headers (closes ... #2034

Closed
wants to merge 1 commit into from

5 participants

@wsnipex
Collaborator

...#13647)

reordered lame checks. Look for the header first and only after it is found, check the lib too. Otherwise configure will throw "too many arguments" warnings

@davilla

and what is the real cause of the "too many arguments" warnings ?

@wsnipex
Collaborator

if you don't check for the header first, test compilation in XB_FIND_SONAME fails. Iirc the warning then comes in the "gold linker syntax" part. And I didn't find a better way to cleanly check check this, but suggestions are welcome.
It'd be easier if lame support was not auto.

@arnova
Collaborator

Note that those "too many arguments" warnings occur with all our libs due to the way we detect for gold linker syntax. I had this on my todo-list to properly fix it, but since it's a lot of work I didn't bother yet.

@arnova
Collaborator

Just had a quick look, and the fix for the gold linker check seems rather trivial actually: arnova@ebea889

@theuni
Owner

verified working fix for gold:

diff --git a/configure.in b/configure.in
index f037c2f..7ddcff1 100644
--- a/configure.in
+++ b/configure.in
@@ -59,7 +59,7 @@ AC_DEFUN([XB_FIND_SONAME],
     $1_FILENAME=$($CC -nostdlib -o /dev/null $LDFLAGS -l$2 -Wl,-M 2>/dev/null | grep "^LOAD.*$2" | awk '{V=2; print $V}')
     if [[ -z $$1_FILENAME ]]; then
       #try gold linker syntax
-      $1_FILENAME=$($CC -nostdlib -o /dev/null $LDFLAGS -l$2 -Wl,-t 3>&1 1>&2 2>&3 | grep "$2")
+      $1_FILENAME=$($CC -nostdlib -o /dev/null $LDFLAGS -l$2 -Wl,-t 3>&1 1>&2 2>&3 | grep "lib$2")
     fi
     if [[ ! -z $$1_FILENAME ]]; then
       $1_SONAME=$($OBJDUMP -p $$1_FILENAME | grep "SONAME.*$2" | awk '{V=2; print $V}')
@theuni
Owner

Please use the above, as it addresses the real issue

@wsnipex
Collaborator

jenkins build this please

@Memphiz
Owner

pr is to old and not in the jenkins idx ...

@wsnipex wsnipex closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 4, 2013
  1. @wsnipex
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  configure.in
View
2  configure.in
@@ -59,7 +59,7 @@ AC_DEFUN([XB_FIND_SONAME],
$1_FILENAME=$($CC -nostdlib -o /dev/null $LDFLAGS -l$2 -Wl,-M 2>/dev/null | grep "^LOAD.*$2" | awk '{V=2; print $V}')
if [[ -z $$1_FILENAME ]]; then
#try gold linker syntax
- $1_FILENAME=$($CC -nostdlib -o /dev/null $LDFLAGS -l$2 -Wl,-t 3>&1 1>&2 2>&3 | grep "$2")
+ $1_FILENAME=$($CC -nostdlib -o /dev/null $LDFLAGS -l$2 -Wl,-t 3>&1 1>&2 2>&3 | grep "lib$2")
fi
if [[ ! -z $$1_FILENAME ]]; then
$1_SONAME=$($OBJDUMP -p $$1_FILENAME | grep "SONAME.*$2" | awk '{V=2; print $V}')
Something went wrong with that request. Please try again.