Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyboard] fix Chinese character coding issue in keyboard layout #20427

Merged
merged 1 commit into from Nov 15, 2021

Conversation

taxigps
Copy link
Member

@taxigps taxigps commented Oct 31, 2021

Description

fix character coding problem with Keyboard layouts Chinese BasePY under windows .

Motivation and context

see: #17168

How has this been tested?

What is the effect on users?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@taxigps taxigps added Type: Fix non-breaking change which fixes an issue Backport: Needed v20 Nexus labels Oct 31, 2021
@taxigps taxigps requested a review from garbear as a code owner October 31, 2021 00:46
@taxigps taxigps self-assigned this Oct 31, 2021
@taxigps taxigps added this to the Nexus 20.0 Alpha 1 milestone Oct 31, 2021
@jenkins4kodi
Copy link
Contributor

I've made some formatting changes to meet the current code style. The diffs are available in the following links:

For more information please see our current code style guidelines.

@taxigps taxigps requested review from enen92 and garbear and removed request for garbear and enen92 November 1, 2021 14:23
Copy link
Contributor

@fuzzard fuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar layout style to the Korean one. I can't really test, so take your word on it working, but doesn't look like there's any troubles with it

@taxigps
Copy link
Member Author

taxigps commented Nov 15, 2021

@fuzzard Thanks! I have tested it, it works well.

@taxigps taxigps merged commit 6433032 into xbmc:master Nov 15, 2021
@taxigps taxigps deleted the keyboard branch November 15, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Input Type: Fix non-breaking change which fixes an issue v20 Nexus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants