Change default musicvideo scraper because it's broken #2113

Merged
merged 3 commits into from Jan 25, 2013

Conversation

Projects
None yet
5 participants
@MartijnKaijser
Member

MartijnKaijser commented Jan 24, 2013

@zag2me
Up to you if you are ok with this.

@Montellese

This comment has been minimized.

Show comment Hide comment
@Montellese

Montellese Jan 24, 2013

Member

Just changing the initial value of the scraper setting isn't enough in case of an update because the value stored in guisettings.xml will overwrite whatever initial value we set. So anyone updating from Eden to Frodo will still run into the broken addon. But I don't think there's much we can do about it.

Member

Montellese commented Jan 24, 2013

Just changing the initial value of the scraper setting isn't enough in case of an update because the value stored in guisettings.xml will overwrite whatever initial value we set. So anyone updating from Eden to Frodo will still run into the broken addon. But I don't think there's much we can do about it.

@MartijnKaijser

This comment has been minimized.

Show comment Hide comment
@MartijnKaijser

MartijnKaijser Jan 24, 2013

Member

Or we have to change the stored value as well like you did for some other cases.

Member

MartijnKaijser commented Jan 24, 2013

Or we have to change the stored value as well like you did for some other cases.

@jmarshallnz

This comment has been minimized.

Show comment Hide comment
@jmarshallnz

jmarshallnz Jan 24, 2013

Member

if (setting is lastfm)
update setting to theaudiodb

Member

jmarshallnz commented Jan 24, 2013

if (setting is lastfm)
update setting to theaudiodb

[addons] Change default musicvideo scraper from the broken last.fm to…
… theaudiodb.com. In case last.fm was still in use replace it with theaudiodb.com
@MartijnKaijser

This comment has been minimized.

Show comment Hide comment
@MartijnKaijser

MartijnKaijser Jan 24, 2013

Member

updated

Member

MartijnKaijser commented Jan 24, 2013

updated

@Montellese

This comment has been minimized.

Show comment Hide comment
@Montellese

Montellese Jan 24, 2013

Member

Yup but that only helps for any newly created musicvideo sources. For any existing musicvideo sources the scraper for that source will still be set to Last.FM.

Member

Montellese commented Jan 24, 2013

Yup but that only helps for any newly created musicvideo sources. For any existing musicvideo sources the scraper for that source will still be set to Last.FM.

@zag2me

This comment has been minimized.

Show comment Hide comment
@zag2me

zag2me Jan 25, 2013

I don't think my site can handle this to be honest. I'd at the very least need some time to prepare it.

zag2me commented Jan 25, 2013

I don't think my site can handle this to be honest. I'd at the very least need some time to prepare it.

@zag2me

This comment has been minimized.

Show comment Hide comment
@zag2me

zag2me Jan 25, 2013

Musicvideo scraper is hugely resource intensive I'd imagine? Does it check every track in someone's database?

zag2me commented Jan 25, 2013

Musicvideo scraper is hugely resource intensive I'd imagine? Does it check every track in someone's database?

@MartijnKaijser

This comment has been minimized.

Show comment Hide comment
@MartijnKaijser

MartijnKaijser Jan 25, 2013

Member

I doubt if many people actually use musicvideos. It's not as huge an audience as artists and albums so my guess is it will only be a fraction of current API traffic.
Perhaps you can see in your server stats what part accounts for musicvideo scraping and how it's handled?
atm yours is the only other option as scraper. if yours can't handle it we can perhaps set no default scraper and just let user decide?

Member

MartijnKaijser commented Jan 25, 2013

I doubt if many people actually use musicvideos. It's not as huge an audience as artists and albums so my guess is it will only be a fraction of current API traffic.
Perhaps you can see in your server stats what part accounts for musicvideo scraping and how it's handled?
atm yours is the only other option as scraper. if yours can't handle it we can perhaps set no default scraper and just let user decide?

@Montellese

This comment has been minimized.

Show comment Hide comment
@Montellese

Montellese Jan 25, 2013

Member

I once played around with the default scraper settings and having an invalid (i.e. non-existing) or empty default scraper will result in very odd behaviour of the "Set content" dialog. Sometimes I wasn't even able to get to the "Get More..." button and the content-options at the lower half of the dialog were actually the ones from movie content and not the one from musicvideo content. So we should avoid setting no or an empty default scraper.

Member

Montellese commented Jan 25, 2013

I once played around with the default scraper settings and having an invalid (i.e. non-existing) or empty default scraper will result in very odd behaviour of the "Set content" dialog. Sometimes I wasn't even able to get to the "Get More..." button and the content-options at the lower half of the dialog were actually the ones from movie content and not the one from musicvideo content. So we should avoid setting no or an empty default scraper.

@MartijnKaijser

This comment has been minimized.

Show comment Hide comment
@MartijnKaijser

MartijnKaijser Jan 25, 2013

Member

@Montellese
I made a ticket about that issue.

We some other default scraper if possible or get a working API key again

Member

MartijnKaijser commented Jan 25, 2013

@Montellese
I made a ticket about that issue.

We some other default scraper if possible or get a working API key again

@ronie

This comment has been minimized.

Show comment Hide comment
@ronie

ronie Jan 25, 2013

Member

as a last resort, we still have a yahoo musicvideo scraper in eden repo.
it's not marked as broken, so i assume it's still functional?

getting a new last.fm key is meh.
for all we know they'll disable it the minute we start using it.

Member

ronie commented Jan 25, 2013

as a last resort, we still have a yahoo musicvideo scraper in eden repo.
it's not marked as broken, so i assume it's still functional?

getting a new last.fm key is meh.
for all we know they'll disable it the minute we start using it.

@zag2me

This comment has been minimized.

Show comment Hide comment
@zag2me

zag2me Jan 25, 2013

OK lets do this! Feel free to add theaudiodb.com as the default scraper.

I'll work on beefing up the server

zag2me commented Jan 25, 2013

OK lets do this! Feel free to add theaudiodb.com as the default scraper.

I'll work on beefing up the server

MartijnKaijser added a commit that referenced this pull request Jan 25, 2013

Merge pull request #2113 from MartijnKaijser/scraper_change
Change default musicvideo scraper because it's broken

@MartijnKaijser MartijnKaijser merged commit 61e0135 into xbmc:master Jan 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment