Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

DVDAudioCodecFFmpeg: Convert unknown audio formats to float. #2117

Merged
merged 1 commit into from Jan 25, 2013

Conversation

Projects
None yet
3 participants
Contributor

aballier commented Jan 25, 2013

As of FFmpeg-1.1, some decoders started to output planar audio.
This fixes track ticket 13944.

This will be needed when we'll update the internal FFmpeg to a newer release.
It's not my call but it'd be cool if this were backported to Frodo as it fixes a crash.

TODO: I fear passthrough is affected too, will have a look, but this one was easy enough.

@aballier aballier DVDAudioCodecFFmpeg: Convert unknown audio formats to float.
As of FFmpeg-1.1, some decoders started to output planar audio.
This fixes track ticket 13944.
49eebad
Member

elupus commented Jan 25, 2013

That assert there looks evil. We should handle that case gracefully too.

This looks ok for frodo.

@davilla davilla added a commit that referenced this pull request Jan 25, 2013

@davilla davilla Merge pull request #2117 from aballier/unknownaudioout
DVDAudioCodecFFmpeg: Convert unknown audio formats to float.
0a6806f

@davilla davilla merged commit 0a6806f into xbmc:master Jan 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment