paplayer handle prepare stream failure. #2129

Merged
merged 1 commit into from Jan 29, 2013

Conversation

Projects
None yet
2 participants
@ulion
Contributor

ulion commented Jan 28, 2013

I've encountered a crash in gdb after log message:

PAPlayer::PrepareStream - Failed to get IAEStream 

what cause crash is at line in PAPlayer::ProcessStream with si->m_stream == NULL:

    si->m_stream->RegisterAudioCallback(m_audioCallback);

I checked only place called PrepareStream is in PAPlayer::QueueNextFileEx where did not check failure, so here is the fix for it, please check whether it is correct..

@Memphiz

This comment has been minimized.

Show comment
Hide comment
@Memphiz

Memphiz Jan 28, 2013

Member

Any idea why preparestream fails? Though this looks good to me.

@jmarshallnz or whoever has a second opinion?

Member

Memphiz commented Jan 28, 2013

Any idea why preparestream fails? Though this looks good to me.

@jmarshallnz or whoever has a second opinion?

@ulion

This comment has been minimized.

Show comment
Hide comment
@ulion

ulion Jan 28, 2013

Contributor

this stream hit NULL normally not happens, but when the auido engine is suspended.
when I testing my ios code, my code sometimes didn't resume audio engine before play an item, which will wake up this crash, fix it is harmless and prevent unhappy crash anyway.
the log message updated.

Contributor

ulion commented Jan 28, 2013

this stream hit NULL normally not happens, but when the auido engine is suspended.
when I testing my ios code, my code sometimes didn't resume audio engine before play an item, which will wake up this crash, fix it is harmless and prevent unhappy crash anyway.
the log message updated.

Memphiz added a commit that referenced this pull request Jan 29, 2013

@Memphiz Memphiz merged commit 1b3e098 into xbmc:master Jan 29, 2013

@Memphiz

This comment has been minimized.

Show comment
Hide comment
@Memphiz

Memphiz Jan 29, 2013

Member

thx

Member

Memphiz commented Jan 29, 2013

thx

@ulion ulion deleted the ulion:paplayer_prepare_stream_failure branch Feb 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment