[GUI] Show the language of audio tracks in the audio settings dialog #2156

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Member

ace20022 commented Feb 1, 2013

This adds the language or "unknown" in front of a audio track name.
For example: English - 2/0 - AC3 Stereo.

possible unrelated change ?

Owner

ace20022 replied Feb 1, 2013

Just to make things easier in the gui logic. Basically the problem is that s.name is also set this way and that
nav->GetAudioStreamLanguage(i); returns the full language name and not a code, cf. my 1st. comment.

Member

ace20022 commented Feb 1, 2013

While implementing this I noticed that the stream details of dvd tracks aren't set properly.
Will address this issue in a separate PR eventually.

Member

elupus commented Feb 1, 2013

Hmm.. Seems we should make sure language is not included in name in the
player? Detecting that at display seem wrong.

Member

ace20022 commented Feb 1, 2013

Agree, I just wanted to keep this PR minimal w.r.t. code changes.
The same problems occur regarding subtitles, I would also open a separate PR for that.

Member

ace20022 commented Feb 1, 2013

fyi I started to work on the root issue: https://github.com/ace20022/xbmc/commits/unify_stream_lang
I will open a PR once it's ready.

Member

ace20022 commented Feb 2, 2013

I opened an advanced PR at PR #2162 .

ace20022 closed this Feb 2, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment