subtitle addons restructuring(retry of #1444) #2225

Closed
wants to merge 5 commits into
from

Projects

None yet

7 participants

Contributor
amet commented Feb 12, 2013
  • xbmc.python.subtitles hidden in addons manager
  • create xbmc.subtitle.module so that subtitle addon services can be installed as modules

as in #1444, I cant amend there so this is a new PR.

nothing has changed since as i am not sure what direction is wanted/needed, this will greatly help in maintaining and keeping update intervals to a minimum and only to a needed services.

thoughts?

Contributor
amet commented Feb 15, 2013

if no one has any objections in 2 days I am pushing this in to give us enough time to test new addons and official repo

Member

How do you handle the Frodo repo? Does the main subs script still come with the services for that?

Contributor
amet commented Feb 15, 2013

@jmarshallnz

Frodo has all services bundled in as you can see here as I was apparently too late with including this into mainline for frodo and will stay like that until Gotham is out ... unless we feel its safe to push it in 12.1(2), but I wouldn't hold my breath for that.

Gotham branch has a GUI only version that will be hidden if this PR goes in and Service will depend on it(version needs a 5.0.0 bump)

I want every service to return a locally downloaded file and GUI will process that, just move it around and rename accordingly. we shouldnt, nor do we want to, worry about downloads and compressed files and all other issues, service needs to do all that. having it simple as that would allow us to move the GUI function into core later on if we feel its necessary.

Member

Yup, the API can't change for 12.X, so it'll be Gotham for sure. I guess you're relying on a separate repo/separate versions being available until Gotham as Frodo is phased out?

Contributor
amet commented Feb 16, 2013

yes, we would need a Gotham official repo started. I have maintained 2 versions in parallel ever since I started doing this so it wont be an issue.

Contributor
amet commented Feb 20, 2013

@jmarshallnz if this is not something we want just let me know... or if it needs more work.... but I feel we need to address the service split one way or the other

Member

There's still a while until next merge window, so no rush ATM. The way it's
arranged looks fine to me ATM as a first step.
On Feb 21, 2013 5:54 AM, "Zeljko Ametovic" notifications@github.com wrote:

@jmarshallnz https://github.com/jmarshallnz if this is not something we
want just let me know... or if it needs more work.... but I feel we need to
address the service split one way or the other


Reply to this email directly or view it on GitHubhttps://github.com/xbmc/xbmc/pull/2225#issuecomment-13842703.

Contributor
amet commented Feb 21, 2013

@jmarshallnz cool, I am just nervous about it as last time I was told no rush we hit frodo :)

Contributor
amet commented Mar 3, 2013

@jmarshallnz , @theuni .. anything? I would like this in if possible

Contributor
davilla commented Mar 3, 2013

@jmarshallnz , @theuni, tick, tock, tick, tock :)

Member
theuni commented Mar 3, 2013

@amet: a quick thought, though it's unlikely... Would it be possible for this to coexist in Frodo? Meaning, make the modules depend on xbmc.subtitle.module, which would not be present in the Frodo repo, but shipped with Gotham.

Member
theuni commented Mar 3, 2013

The reason I ask is because (as we've discussed), I'd like to move towards a single repo where addons are filtered by apis rather than starting over with each release.

Member
ronie commented Mar 4, 2013

am i correct in understanding we also need a gotham addon repo as soon as this goes in?

Contributor
amet commented Mar 4, 2013

@ronie yes you are correct, -pre at least

Contributor
amet commented Mar 4, 2013

@theuni we could make modules depend on a totally new subtitle addon(GUI part) and push it all in frodo repo, ATM same xbmc subtitle addon ID is used for testing, we could create clean slate and let everyone use a new one.

Not sure how we can hide modules and the new GUI addon from current frodo users, would API filter that?

Member
theuni commented Mar 4, 2013

@ronie My idea above was to push it into Frodo. This will make for a good test for properly splitting apis.

@amet Yea, it will need to depend on some meta-addon, then it will be hidden. Probably the most sane way to do it is to have addon.subtitle.foo depend on xbmc.subtitle.module, then xbmc.subtitle.module depend on xbmc.addon > 12.9.1, or something along those lines.

Member

The UI addon bit would need to be a different addon ID for it to work I think, else Frodo users would get the new cut down one which is useless to them, right? The subtitle modules won't be visible as Frodo doesn't know what they are, so they won't be installed or listed I think? This ofcourse needs testing - it may be that there's a bunch of logging done about addons that are unknown if these are in the repository (you'd need to generate an addons.xml with the modules in place).

On the one repo thing, I'm not sure it's going to work, given the current code in Frodo. We always assume that the latest version available among all repositories is the one that should be installed, regardless of whether it has met or unmet dependencies. IIRC we don't bother checking dependencies before we prompt for install, and there is no support anywhere for multiple versions of the same addon in the addon database. It might be worth opening a thread to discuss exactly how this is going to work.

Contributor
amet commented Mar 5, 2013

@theuni I have thought of it differently... Modules depend on addon.subtitle.foo which is hidden, you only need to install a module/service and you get the UI with it.

@jmarshallnz correct, they won't be visible in Frodo but I am not sure about the log spew

Contributor
amet commented Mar 5, 2013

if we have a new addon, with different ID, then if dependencies are not met it will not show up for installation. dependencies will be met only on nightly(v13) of XBMC.

what I have is a test repo for this, I have made UI script depend on and it shows as "broken" in Frodo and log is silent about "xbmc.subtitle.module" being in repo, it just gets ignored.

Member
da-anda commented Mar 5, 2013

can't we add the needed repo logic to 12.1 in case a tiny bit is missing in order to not list incompatible addons instead of marking them broken?

Contributor
amet commented Mar 5, 2013

would probably work but its not my call to make, @davilla or someone who knows insides of it should comment

Member
theuni commented Mar 6, 2013

Ok, talked this over at length with @amet on irc.

Plan is to go ahead and create a gotham subtitles repo, and ship it with xbmc. This is temporary, and all will be unified for Gotham release. But for now, we need a distinction, since it's unfortunately too hackish to try to make everything coexist. If there's major opposition to that, the repo could always be distributed as a zip instead.

I'll get the repo up and going, and amet will get a few things pushed in there. We'll add the repository addon to this PR, and once it's all verified working we'll hit the button.

It's not the prettiest, but amet's waited long enough for this.

Member

Sounds good to me.

Contributor
amet commented Mar 6, 2013

@theuni please check if Gotham repo is okay...once you are done I'll push what I have in there and start testing

Contributor
amet commented Mar 8, 2013

@jmarshallnz

I have added another commit here that allows us to set addon and settings for it in video->subtitle section of XBMC, its one more step closer to moving all subtitle settings into one place.

one thing that I cannot do is use newly created "subtitle.addon" setting from guisettings.xml in subtitle button on OSD. I was told that skin can only get system.getbool() settings out of it... can you think of a way to make this easier than setting the same addon twice, once in settings and once in OSD?

amet and others added some commits Sep 21, 2012
@amet amet subtitle addons restructuring
- xbmc.python.subtitles hidden in addons manager
- create xbmc.subtitle.module so that subtitle addon services can be installed as modules
98ca897
@amet amet add Gotham Repo 3b8b5dd
@amet amet add ability to set subtitle download addon and settings in video->sub…
…titles
2040e0c
@ronie ronie add subtitles addon info label 272dedc
@ronie ronie [Confluence] use subtitles addon infolabel b8af3d6
Member
ronie commented Mar 8, 2013

make the selected subtitle addon id available to the skin as an infolabel.

Member
theuni commented Mar 10, 2013

amet: are we ready to go on this?

@amet amet closed this May 4, 2013
@amet amet deleted the unknown repository branch Jan 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment