Added property to show tvshow/season progress in % #2254

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
7 participants
@phil65
Member

phil65 commented Feb 18, 2013

Adds a new property "percentplayed" for tvshows and seasons which returns the amount of played episodes in percent.
also useful to display a progress image, here´s an example of what we skinners can do with it:
http://i.imgur.com/cx43M6L.jpg (tvshow level)
http://i.imgur.com/f8J7V5X.jpg (season level)

if you know a more elegant way to cast the data types let me know :)
same goes for the label, not sure if "percentplayed" is the best choice.

@t-nelson

This comment has been minimized.

Show comment Hide comment
@t-nelson

t-nelson Feb 18, 2013

Contributor

There's no sense dirtying the diff by introducing those temporary variables. Cosmetic stuff like that should always be in a separate commit.

Contributor

t-nelson commented Feb 18, 2013

There's no sense dirtying the diff by introducing those temporary variables. Cosmetic stuff like that should always be in a separate commit.

@jmarshallnz

This comment has been minimized.

Show comment Hide comment
@jmarshallnz

jmarshallnz Feb 18, 2013

Member

Shouldn't it be percentwatched?

Member

jmarshallnz commented Feb 18, 2013

Shouldn't it be percentwatched?

@phil65

This comment has been minimized.

Show comment Hide comment
@phil65

phil65 Feb 18, 2013

Member

percentwatched is also fine. :)
I´ll remove the temporary variables and change the property label then.

Member

phil65 commented Feb 18, 2013

percentwatched is also fine. :)
I´ll remove the temporary variables and change the property label then.

@phil65

This comment has been minimized.

Show comment Hide comment
@phil65

phil65 Feb 18, 2013

Member

PR updated.

Member

phil65 commented Feb 18, 2013

PR updated.

@pieh

This comment has been minimized.

Show comment Hide comment
@pieh

pieh Feb 19, 2013

Member

About label name, we have ListItem.PercentPlayed to mark how much of the video was played and this introduce ListItem.Property(PercentWatched) - shouldn't these 2 be unified?

Member

pieh commented Feb 19, 2013

About label name, we have ListItem.PercentPlayed to mark how much of the video was played and this introduce ListItem.Property(PercentWatched) - shouldn't these 2 be unified?

@phil65

This comment has been minimized.

Show comment Hide comment
@phil65

phil65 Feb 19, 2013

Member

hmm i think it makes more sense to have them separated since they return different stuff + we also use property() for the related infos 'totalepisodes', 'watchedepisodes' etc

thx for the suggestion, will update the PR in the evening.

Member

phil65 commented Feb 19, 2013

hmm i think it makes more sense to have them separated since they return different stuff + we also use property() for the related infos 'totalepisodes', 'watchedepisodes' etc

thx for the suggestion, will update the PR in the evening.

@phil65

This comment has been minimized.

Show comment Hide comment
@phil65

phil65 Feb 19, 2013

Member

PR updated again.

Member

phil65 commented Feb 19, 2013

PR updated again.

@pieh

This comment has been minimized.

Show comment Hide comment
@pieh

pieh Mar 8, 2013

Member

Seems good to me. @jmarshallnz, final word?

Member

pieh commented Mar 8, 2013

Seems good to me. @jmarshallnz, final word?

@snowjim

This comment has been minimized.

Show comment Hide comment
@snowjim

snowjim Mar 24, 2013

This is really annoying feature. When a episode is set as watched and then I check to see that I really seen it the progress icon will be shown instead of the progress icon. And if I hit the w for watched I will still not get the watched icon back? I have looked all over the place to turn this progress icon off but there is none?

snowjim commented Mar 24, 2013

This is really annoying feature. When a episode is set as watched and then I check to see that I really seen it the progress icon will be shown instead of the progress icon. And if I hit the w for watched I will still not get the watched icon back? I have looked all over the place to turn this progress icon off but there is none?

@MartijnKaijser

This comment has been minimized.

Show comment Hide comment
@MartijnKaijser

MartijnKaijser Mar 24, 2013

Owner

@snowjim
This is an area for devs and not for users. Besides there's no point in asking in three places. Stick with the forum.

Owner

MartijnKaijser commented Mar 24, 2013

@snowjim
This is an area for devs and not for users. Besides there's no point in asking in three places. Stick with the forum.

@phil65

This comment has been minimized.

Show comment Hide comment
@phil65

phil65 Mar 24, 2013

Member

...and apart from that the comment is also completely wrong because it has nothing to do with this feature.

Member

phil65 commented Mar 24, 2013

...and apart from that the comment is also completely wrong because it has nothing to do with this feature.

@MartijnKaijser

This comment has been minimized.

Show comment Hide comment
@MartijnKaijser

MartijnKaijser Apr 5, 2013

Owner

@jmarshallnz
good to go in?

Owner

MartijnKaijser commented Apr 5, 2013

@jmarshallnz
good to go in?

@jmarshallnz

This comment has been minimized.

Show comment Hide comment
@jmarshallnz

jmarshallnz Apr 5, 2013

Member

Looks OK to me, though I wonder if it's worth adding a static function (say to CVideoDatabase?) that takes in CFileItem, watched, total and assigns all the watched related properties. Saves the same code all over the show.

Member

jmarshallnz commented Apr 5, 2013

Looks OK to me, though I wonder if it's worth adding a static function (say to CVideoDatabase?) that takes in CFileItem, watched, total and assigns all the watched related properties. Saves the same code all over the show.

@alcoheca

This comment has been minimized.

Show comment Hide comment
@alcoheca

alcoheca Apr 6, 2013

Contributor

agree with pieh,

what about a function of CVIdeoInfoTag::PercentageWatched(), which calculates on the fly the percentage watched, be it a tv show(watched/totalepisodes), season (season watched / season episodes) or episode/film/musicvideo (from resume point)

remembering to update all these properties by hand each time is tricky

EDIT: wouldn't work of course as properties are unavailable to VideoInfoTags... moving on

Contributor

alcoheca commented Apr 6, 2013

agree with pieh,

what about a function of CVIdeoInfoTag::PercentageWatched(), which calculates on the fly the percentage watched, be it a tv show(watched/totalepisodes), season (season watched / season episodes) or episode/film/musicvideo (from resume point)

remembering to update all these properties by hand each time is tricky

EDIT: wouldn't work of course as properties are unavailable to VideoInfoTags... moving on

@MartijnKaijser

This comment has been minimized.

Show comment Hide comment
@MartijnKaijser

MartijnKaijser Oct 17, 2013

Owner

@phil65
i'm closing this for now until you will have time to work on this PR.
Create a new one when time comes

Owner

MartijnKaijser commented Oct 17, 2013

@phil65
i'm closing this for now until you will have time to work on this PR.
Create a new one when time comes

@phil65 phil65 deleted the phil65:tvshowprogress branch Oct 16, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment