some settings related cleanup #2258

merged 7 commits into from Mar 4, 2013


None yet
3 participants

Montellese commented Feb 18, 2013

These are the cleanup related commits from #2190. The first two commits only move around some files into (hopefully) better locations and the other commits move some code to load settings files (upnp.xml and playercorefactory.xml) out of CSettings into CUPnPSettings and CPlayerCoreFactory where they IMO belong.


jmarshallnz commented Feb 19, 2013

Assigned to next merge window.

@Memphiz: will need xcode monkeying :)

@Montellese Montellese added a commit that referenced this pull request Mar 4, 2013

@Montellese Montellese Merge pull request #2258 from Montellese/settings_cleanup
some settings related cleanup

@Montellese Montellese merged commit 5e7cc67 into xbmc:master Mar 4, 2013

Montellese deleted the Montellese:settings_cleanup branch Mar 4, 2013

I really wonder whether we should clear the string here at all. See 91fbd97 why...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment