Allow ms value for AlarmClock() #2266

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@phil65
Member

phil65 commented Feb 20, 2013

this commit allows AlarmClock() to take values in milliseconds.
can be useful for skinners (see http://forum.xbmc.org/showthread.php?tid=156191&pid=1337513#pid1337513 )
needs a ms suffix for time parameter (for example, "300ms"), the original behaviour isn´t changed. (still uses minutes when time parameter is an integer)
other way would be to move that to TimeStringToSeconds()

@ghost

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Mar 16, 2013

i think it would be better to use the 'normal' time format i.e. hh:mm:ss

ghost commented Mar 16, 2013

i think it would be better to use the 'normal' time format i.e. hh:mm:ss

@phil65

This comment has been minimized.

Show comment Hide comment
@phil65

phil65 Mar 16, 2013

Member

so hh:mm:ss:ms and dealing with it in TimeStringToSeconds() ?

Member

phil65 commented Mar 16, 2013

so hh:mm:ss:ms and dealing with it in TimeStringToSeconds() ?

@ghost

This comment has been minimized.

Show comment Hide comment
@ghost

ghost Mar 16, 2013

yup

ghost commented Mar 16, 2013

yup

@MartijnKaijser

This comment has been minimized.

Show comment Hide comment
@MartijnKaijser

MartijnKaijser Oct 17, 2013

Owner

@phil65
i'm closing this for now until you will have time to work on this PR.
Create a new one when time comes

Owner

MartijnKaijser commented Oct 17, 2013

@phil65
i'm closing this for now until you will have time to work on this PR.
Create a new one when time comes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment