fix ass subs for GLES #2273

Merged
merged 1 commit into from Feb 22, 2013

6 participants

@FernetMenta
Team Kodi member

see title

@popcornmix
Team Kodi member

Confirmed working on Pi. CPU usage massively lower when playing files with ASS/SSA subs.
Good job!

@popcornmix
Team Kodi member

@theuni
Yes it was broken. On Pi it was taking over a second (with m_count=828) to render ASS subs...

@theuni
Team Kodi member

@popcornmix not sure I'd call that broken (I was speaking in terms of whether it should be backported to Frodo or not), but since you could certainly argue that it was so inefficient that it didn't work before on some platforms but it works now, I'd have no problem with that.

@FernetMenta +1.

@davilla

@Memphiz can you check iOS ?

@FernetMenta
Team Kodi member

@theuni

Also, though it wasn't there before, we should probably add a quick sanity check to be sure that m_count > 0, since everything else hinges on it.

like this?

  if (m_texture == 0 || m_count == 0)
    return;
@theuni
Team Kodi member

should be fine, yea. I really doubt it's necessary, as it looks like quads must've been set to something to get that far. but it doesn't hurt.

@davilla

+1, works fine under pivos amlogic arm SoCs which use mali.

@Memphiz
Team Kodi member

will test on ios in a min.

@Memphiz
Team Kodi member

works fine on ios.

@FernetMenta FernetMenta merged commit 9599872 into xbmc:master Feb 22, 2013
@FernetMenta FernetMenta deleted the FernetMenta:assfix branch Feb 22, 2013
@riso

wow thank you. been waiting for this for a long time. great job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment