GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
No description provided.
I stumbled upon this because the ms compiler spits out two warnings for this file:
\xbmc\guilib\guikeyboardfactory.cpp(115): warning C4800: 'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
\xbmc\guilib\guikeyboardfactory.cpp(135): warning C4800: 'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
I can't figure out why these are there, but by what I found (http://stackoverflow.com/questions/1847860/why-is-there-a-performance-warning-on-cast-pointer-to-bool), I think it can be ignored?
Count the parameters. As it looks like unsigned int autoCloseMs is supposed to be the last parameter but is set on the place of bool hiddeninput which produces the performance warning. I would say we miss a parameter there :)
Good catch wsoltys ... when introducing the autoclosems i forgot to explicitly set the bhiddeninput bool (it defaults to false) - at those 2 places.
@wsoltys super! I tried had to count them with my fingers, but they aren't what they were once ;)
this is exactly why I dislike auto set default params :)
ace20022 you wanna update your pr or should i just go for it bypassing you?
[Cosmetic] Remove superfluous "!= 0"
[fix] Add lost parameter.
Merge pull request #2280 from ace20022/cosmetic
[Fix] Add lost parameter in GUIKeyboardFactory