[Fix] Add lost parameter in GUIKeyboardFactory #2280

Merged
merged 2 commits into from Feb 23, 2013

Conversation

Projects
None yet
4 participants
Member

ace20022 commented Feb 22, 2013

No description provided.

Member

ace20022 commented Feb 22, 2013

I stumbled upon this because the ms compiler spits out two warnings for this file:

\xbmc\guilib\guikeyboardfactory.cpp(115): warning C4800: 'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)
\xbmc\guilib\guikeyboardfactory.cpp(135): warning C4800: 'unsigned int' : forcing value to bool 'true' or 'false' (performance warning)

I can't figure out why these are there, but by what I found (http://stackoverflow.com/questions/1847860/why-is-there-a-performance-warning-on-cast-pointer-to-bool), I think it can be ignored?
Other ideas?

Member

wsoltys commented Feb 22, 2013

Count the parameters. As it looks like unsigned int autoCloseMs is supposed to be the last parameter but is set on the place of bool hiddeninput which produces the performance warning. I would say we miss a parameter there :)

Owner

Memphiz commented Feb 22, 2013

Good catch wsoltys ... when introducing the autoclosems i forgot to explicitly set the bhiddeninput bool (it defaults to false) - at those 2 places.

Member

ace20022 commented Feb 22, 2013

@wsoltys super! I tried had to count them with my fingers, but they aren't what they were once ;)

Contributor

davilla commented Feb 22, 2013

this is exactly why I dislike auto set default params :)

Owner

Memphiz commented Feb 22, 2013

ace20022 you wanna update your pr or should i just go for it bypassing you?

Member

ace20022 commented Feb 23, 2013

@Memphiz correct?

Memphiz added a commit that referenced this pull request Feb 23, 2013

Merge pull request #2280 from ace20022/cosmetic
[Fix] Add lost parameter in GUIKeyboardFactory

@Memphiz Memphiz merged commit 8123a39 into xbmc:master Feb 23, 2013

Owner

Memphiz commented Feb 23, 2013

Thx

@ace20022 ace20022 deleted the ace20022:cosmetic branch Feb 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment