Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Silence warnings double -> int #2291

Merged
merged 2 commits into from

2 participants

@ace20022
Collaborator

No description provided.

@ace20022

Thanks @popcornmix! for the hint.

@jmarshallnz jmarshallnz merged commit a867f7d into xbmc:master
@ace20022

@jmarshallnz It just came into my mind that this yields a different result than before if m_sink_frameSize * format.m_sampleRate > UINT_MAX. Is this case is reasonable?

Nope, that would mean an insane sample rate PR number of channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
2  xbmc/Application.cpp
@@ -2833,7 +2833,7 @@ bool CApplication::OnAction(const CAction &action)
if(core != EPC_NONE)
{
g_application.m_eForcedNextPlayer = core;
- item.m_lStartOffset = GetTime() * 75;
+ item.m_lStartOffset = (int)(GetTime() * 75);
PlayFile(item, true);
}
}
View
2  xbmc/cores/AudioEngine/Sinks/AESinkNULL.cpp
@@ -52,7 +52,7 @@ bool CAESinkNULL::Initialize(AEAudioFormat &format, std::string &device)
// setup a pretend 500ms internal buffer
m_sink_frameSize = format.m_channelLayout.Count() * CAEUtil::DataFormatToBits(format.m_dataFormat) >> 3;
- m_sinkbuffer_size = (double)m_sink_frameSize * format.m_sampleRate / 2;
+ m_sinkbuffer_size = m_sink_frameSize * format.m_sampleRate / 2;
m_sinkbuffer_sec_per_byte = 1.0 / (double)(m_sink_frameSize * format.m_sampleRate);
m_draining = false;
Something went wrong with that request. Please try again.