Fix empty music title announce. #2324

Merged
merged 1 commit into from Mar 1, 2013

Projects

None yet

2 participants

@ulion
Collaborator
ulion commented Mar 1, 2013

some music file has empty music info tag, fix the empty title announce.

@Montellese Montellese commented on the diff Mar 1, 2013
xbmc/interfaces/AnnouncementManager.cpp
@@ -190,7 +190,10 @@ void CAnnouncementManager::Announce(AnnouncementFlag flag, const char *sender, c
// TODO: Can be removed once this is properly handled when starting playback of a file
item->SetProperty(LOOKUP_PROPERTY, false);
- object["item"]["title"] = item->GetMusicInfoTag()->GetTitle();
+ CStdString title = item->GetMusicInfoTag()->GetTitle();
@Montellese
Montellese Mar 1, 2013 Member

Do we really need an extra variable here?

@Montellese
Member

Looks fine.

@ulion ulion merged commit 40c1fc9 into xbmc:master Mar 1, 2013
@ulion ulion deleted the ulion:fix_empty_music_title_in_announce branch Apr 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment