GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
After last commit, I broke menu sounds, cause of a too large buffer. The menu sounds problem has to be investigated separately. Until this happens, let us go back to save values.
Advantage over the old values are, that periodSize and bufferSize scale with the sampleRate. The fix of the menu sounds is, that hopefully no one realizes 200ms waiting time in the menus.
I will look into menu sounds later, something like "drain when there is nothing playing" and don't eat silence if not forced - we will see.
@elupus: I hope the larger buffer can come back, as it is rather great for movie playback
@anssih: thx for review
AE: Fix menu sounds by decreasing buffer(max 200 ms) and periodSize(5…
This is what pulse solves by allowing seeks and rewrites in buffers. As
long as ae thread is high priority and we have buffers somewhere higher up
in the stack it should be fine anyway.
Jep, we buffer directly in SoftAEStream, roughly 0.75 seconds there.
i can confirm it fixes the underrun issues introduced by PR 2320
@davilla: Short ping before the merge window ends. If it is still okay on your Pivos than it should go in - if not we need a even more failsafe default.
Merge pull request #2382 from fritsch/ae-clip-buffer
AE: Fix menu sounds decreasing buffer(max 200 ms) and periodSize(50 ms)