AE: Fix menu sounds decreasing buffer(max 200 ms) and periodSize(50 ms) #2382

Merged
merged 1 commit into from Mar 10, 2013

Conversation

Projects
None yet
4 participants
Member

fritsch commented Mar 6, 2013

After last commit, I broke menu sounds, cause of a too large buffer. The menu sounds problem has to be investigated separately. Until this happens, let us go back to save values.

Advantage over the old values are, that periodSize and bufferSize scale with the sampleRate. The fix of the menu sounds is, that hopefully no one realizes 200ms waiting time in the menus.

I will look into menu sounds later, something like "drain when there is nothing playing" and don't eat silence if not forced - we will see.

@elupus: I hope the larger buffer can come back, as it is rather great for movie playback
@anssih: thx for review

Member

elupus commented Mar 6, 2013

This is what pulse solves by allowing seeks and rewrites in buffers. As
long as ae thread is high priority and we have buffers somewhere higher up
in the stack it should be fine anyway.

Member

fritsch commented Mar 6, 2013

Jep, we buffer directly in SoftAEStream, roughly 0.75 seconds there.

Owner

ronie commented Mar 9, 2013

i can confirm it fixes the underrun issues introduced by PR 2320

Member

fritsch commented Mar 10, 2013

@davilla: Short ping before the merge window ends. If it is still okay on your Pivos than it should go in - if not we need a even more failsafe default.

davilla added a commit that referenced this pull request Mar 10, 2013

Merge pull request #2382 from fritsch/ae-clip-buffer
AE: Fix menu sounds decreasing buffer(max 200 ms) and periodSize(50 ms)

@davilla davilla merged commit 845f8b1 into xbmc:master Mar 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment