Skip to content

[AE] Cleanup things found by Cppcheck #2393

Merged
5 commits merged into from Mar 17, 2013

3 participants

@ace20022
Team Kodi member
ace20022 commented Mar 8, 2013

This time I checked the whole AudioEngine folder.

@ace20022
Team Kodi member
ace20022 commented Mar 8, 2013

Issues I haven't touched:

[Encoders\AEEncoderFFmpeg.cpp:245]: (portability) Casting from float* to integer* is not portable due to different binary data representations on different platforms.
[Engines\CoreAudio\CoreAudioAEHALIOS.cpp:1167]: (performance) Inefficient usage of string::find() in condition; string::compare() would be faster.
[Utils\AEBitstreamPacker.cpp:110] -> [Utils\AEBitstreamPacker.cpp:111]: (performance) Buffer 'm_trueHD' is being written before its old content has been used.

Don't know if these are problematic.

@Memphiz
Team Kodi member
Memphiz commented on 3c14f58 Mar 8, 2013

fine by me - but i guess @davilla will say something about that one :D

yes, iterators should always be pre-incremented.

@ghost
ghost commented Mar 17, 2013

i guess somebody is afraid of evil casting games.

@ghost ghost merged commit 8f3fecd into xbmc:master Mar 17, 2013
@ace20022
Team Kodi member

i guess somebody is afraid of evil casting games.

If I knew you were merging this, I would have removed the [REVIEW] tag from the commit message ;)
Thanks anyway!

@ace20022 ace20022 deleted the ace20022:ae_check branch Apr 3, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.