Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AE] added a method to aefactory to receive the scaled volume. #2398

Closed
wants to merge 1 commit into from
Closed

[AE] added a method to aefactory to receive the scaled volume. #2398

wants to merge 1 commit into from

Conversation

wsoltys
Copy link

@wsoltys wsoltys commented Mar 9, 2013

Moved the setter to it as well. get the volume from the sink if its supported.

I'm unsure if we need some locks in CAEFactory::GetScaledVolume().

…the setter to it as well. get the volume from the sink if its supported.
@DDDamian
Copy link
Contributor

DDDamian commented Mar 9, 2013

@wiso - for this and your other volume PR up to you - mine is always 100% :)

@wsoltys
Copy link
Author

wsoltys commented Mar 10, 2013

Its @wsoltys at github ;)
I also use the avr volume rather than the system volume but if it could be done, why not as it was requested. If the sink supports volume we need to get it back from sink to indicate outside volume changes to xbmc.
The other volume pr needs a revision as the ds sink returns a linear scaled scale but as I understand AE it needs to be different.

@DDDamian
Copy link
Contributor

I'm all in favour - many use volume scaling and I agree the system and XBMC volumes should be locked together. All the more relevent for non-HTPC situations e.g. tablets, laptops, phones etc.

@wsoltys
Copy link
Author

wsoltys commented Sep 9, 2013

obsolete

@wsoltys wsoltys closed this Sep 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants