[AE] added a method to aefactory to receive the scaled volume. #2398

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

wsoltys commented Mar 9, 2013

Moved the setter to it as well. get the volume from the sink if its supported.

I'm unsure if we need some locks in CAEFactory::GetScaledVolume().

@wsoltys wsoltys [AE] added a method to aefactory to receive the scaled volume. Moved …
…the setter to it as well. get the volume from the sink if its supported.
8feb571
Contributor

DDDamian commented Mar 9, 2013

@wiso - for this and your other volume PR up to you - mine is always 100% :)

Member

wsoltys commented Mar 10, 2013

Its @wsoltys at github ;)
I also use the avr volume rather than the system volume but if it could be done, why not as it was requested. If the sink supports volume we need to get it back from sink to indicate outside volume changes to xbmc.
The other volume pr needs a revision as the ds sink returns a linear scaled scale but as I understand AE it needs to be different.

Contributor

DDDamian commented Mar 10, 2013

I'm all in favour - many use volume scaling and I agree the system and XBMC volumes should be locked together. All the more relevent for non-HTPC situations e.g. tablets, laptops, phones etc.

Member

wsoltys commented Sep 9, 2013

obsolete

wsoltys closed this Sep 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment