[AE][DS] fixed: set the right subtype and channelmask. #2399

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@wsoltys
Member

wsoltys commented Mar 9, 2013

I tried to copy some of daniela's directsound changes to the recent ae but can't test unfortunately. @DDDamian: could you comment (and test)? Does it need more to support hd audio?

@DDDamian

This comment has been minimized.

Show comment
Hide comment
@DDDamian

DDDamian Mar 9, 2013

Contributor

@wiso - sure. DS and bitstreaming aren't usually friends as much depends on the shared format set by Windows and other programs, which may force resampling etc, so didn't even try to incorporate (sorry XP folks), but will review/test.

Contributor

DDDamian commented Mar 9, 2013

@wiso - sure. DS and bitstreaming aren't usually friends as much depends on the shared format set by Windows and other programs, which may force resampling etc, so didn't even try to incorporate (sorry XP folks), but will review/test.

@wiso

This comment has been minimized.

Show comment
Hide comment
@wiso

wiso Mar 9, 2013

@DDDamian: wrong person

wiso commented Mar 9, 2013

@DDDamian: wrong person

@DDDamian

This comment has been minimized.

Show comment
Hide comment
@DDDamian

DDDamian Mar 9, 2013

Contributor

@wiso - sorry :) small world!

Contributor

DDDamian commented Mar 9, 2013

@wiso - sorry :) small world!

@wsoltys

This comment has been minimized.

Show comment
Hide comment
@wsoltys

wsoltys Mar 10, 2013

Member

well it seems to have worked for daniela's build and since AE already delivers those formats to ds why not trying to support it. But still I live an learn here :)

Member

wsoltys commented Mar 10, 2013

well it seems to have worked for daniela's build and since AE already delivers those formats to ds why not trying to support it. But still I live an learn here :)

@DDDamian

This comment has been minimized.

Show comment
Hide comment
@DDDamian

DDDamian Mar 10, 2013

Contributor

@wsoltys - actually it didn't (kinda as expected) and we had a discussion about it, but it's buried in that thread somewhere. Will play around this evening and report back, but the issue has always been getting data thru DS untouched - simple in WASAPI, but a house of cards in DS.

Contributor

DDDamian commented Mar 10, 2013

@wsoltys - actually it didn't (kinda as expected) and we had a discussion about it, but it's buried in that thread somewhere. Will play around this evening and report back, but the issue has always been getting data thru DS untouched - simple in WASAPI, but a house of cards in DS.

@DDDamian

This comment has been minimized.

Show comment
Hide comment
@DDDamian

DDDamian Mar 15, 2013

Contributor

@wsoltys - I played around with DS a little further but the basic issues keep rearing their ugly heads (mostly that you can't really enforce what gets out the other side of DS). Here's some of the previous chat on attempting it (goes on for a few pages): http://forum.xbmc.org/showthread.php?tid=121877&pid=1043015#pid1043015

Contributor

DDDamian commented Mar 15, 2013

@wsoltys - I played around with DS a little further but the basic issues keep rearing their ugly heads (mostly that you can't really enforce what gets out the other side of DS). Here's some of the previous chat on attempting it (goes on for a few pages): http://forum.xbmc.org/showthread.php?tid=121877&pid=1043015#pid1043015

@wsoltys

This comment has been minimized.

Show comment
Hide comment
@wsoltys

wsoltys Mar 15, 2013

Member

@DDDamian - I didn't read the whole thread but what I got is that it works good when exclusive mode is checked. But I'll rephase my question:
Does this change make the DirectSound sink:

  1. working better in some circumstances than before?
  2. working worse than the current implementation?
  3. no change?

So if you opt for 1) I'm still fine with implementing it as currently it doesn't work at all when ae is sending hd audio to the ds sink.

Member

wsoltys commented Mar 15, 2013

@DDDamian - I didn't read the whole thread but what I got is that it works good when exclusive mode is checked. But I'll rephase my question:
Does this change make the DirectSound sink:

  1. working better in some circumstances than before?
  2. working worse than the current implementation?
  3. no change?

So if you opt for 1) I'm still fine with implementing it as currently it doesn't work at all when ae is sending hd audio to the ds sink.

@DDDamian

This comment has been minimized.

Show comment
Hide comment
@DDDamian

DDDamian Mar 16, 2013

Contributor

@wsoltys - not so much an exclusive mode thing (DS treats DSSCL_EXLUSIVE the same as DSSCL_PRIORITY since DX8) as keeping the Kernal Mixer out of the equation.

I've got this to work on Win8 (has some improvements over Win7/Vista in the Kernal Mixer that messed about by dithering the audio even when volume is 1.0f), but you'll want to remove:

  • line 371
  • lines 376-378 inclusive
  • line 365 change " const u_int numTests = 6;" to "const u_int numTests = 5;"

My ATI cards & receiver didn't balk at the channel counts, but some might. Probably safer to set them.

Haven't tested on Win7 yet, but will in a day or so with the above changes.

Can throw together a patch with the above if you like.

Contributor

DDDamian commented Mar 16, 2013

@wsoltys - not so much an exclusive mode thing (DS treats DSSCL_EXLUSIVE the same as DSSCL_PRIORITY since DX8) as keeping the Kernal Mixer out of the equation.

I've got this to work on Win8 (has some improvements over Win7/Vista in the Kernal Mixer that messed about by dithering the audio even when volume is 1.0f), but you'll want to remove:

  • line 371
  • lines 376-378 inclusive
  • line 365 change " const u_int numTests = 6;" to "const u_int numTests = 5;"

My ATI cards & receiver didn't balk at the channel counts, but some might. Probably safer to set them.

Haven't tested on Win7 yet, but will in a day or so with the above changes.

Can throw together a patch with the above if you like.

@wsoltys

This comment has been minimized.

Show comment
Hide comment
@wsoltys

wsoltys Mar 16, 2013

Member

@DDDamian - please do so. Thanks.

Member

wsoltys commented Mar 16, 2013

@DDDamian - please do so. Thanks.

@jmarshallnz

This comment has been minimized.

Show comment
Hide comment
@jmarshallnz

jmarshallnz Apr 8, 2013

Member

Any ETA on that patch/testing?

Member

jmarshallnz commented Apr 8, 2013

Any ETA on that patch/testing?

@wsoltys

This comment has been minimized.

Show comment
Hide comment
@wsoltys

wsoltys Sep 9, 2013

Member

obsolete

Member

wsoltys commented Sep 9, 2013

obsolete

@wsoltys wsoltys closed this Sep 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment