pvr: dvdplayer - correct determination if video is playing #2423

Merged
merged 1 commit into from Mar 13, 2013

Conversation

Projects
None yet
5 participants
@FernetMenta
Member

FernetMenta commented Mar 11, 2013

follow-up from #1377

1597 does not fix the entire issue because it does not change anything for VIDEOPLAYER_COVER

@elupus

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Mar 12, 2013

Member

If video goes away away renderer can remain configured. But mainly I don't
like the dependence on rendermanager. Better add a bool in player saying if
it ever found video streams since last open file.

Member

elupus commented Mar 12, 2013

If video goes away away renderer can remain configured. But mainly I don't
like the dependence on rendermanager. Better add a bool in player saying if
it ever found video streams since last open file.

@opdenkamp

This comment has been minimized.

Show comment Hide comment
@opdenkamp

opdenkamp Mar 12, 2013

Member

closed #1377

Member

opdenkamp commented Mar 12, 2013

closed #1377

@FernetMenta

This comment has been minimized.

Show comment Hide comment
@FernetMenta

FernetMenta Mar 12, 2013

Member

elupus, I have updated the pr. I have set the bool to false in the contructor and close because pvr does not open a file on channel change.

Member

FernetMenta commented Mar 12, 2013

elupus, I have updated the pr. I have set the bool to false in the contructor and close because pvr does not open a file on channel change.

@elupus

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Mar 12, 2013

Member

Rename to just m_HasVideo then ok to merge. Imho a bug fix, so can be
merged now.

Member

elupus commented Mar 12, 2013

Rename to just m_HasVideo then ok to merge. Imho a bug fix, so can be
merged now.

dvdplayer: make HasVideo return true if a video stream was opened sin…
…ce playback has started - fixes missing video info on channel change

FernetMenta added a commit that referenced this pull request Mar 13, 2013

Merge pull request #2423 from FernetMenta/videoinfo
pvr: dvdplayer - correct determination if video is playing

@FernetMenta FernetMenta merged commit 0b44ba6 into xbmc:master Mar 13, 2013

@FernetMenta FernetMenta deleted the FernetMenta:videoinfo branch Mar 13, 2013

@FernetMenta

This comment has been minimized.

Show comment Hide comment
@FernetMenta

FernetMenta Mar 15, 2013

Member

@elupus should we set the same strategy for HasAudio? Currently audio visualization pops up for a short while when starting a video. I think this is the reason for that.

Member

FernetMenta commented on bd49c32 Mar 15, 2013

@elupus should we set the same strategy for HasAudio? Currently audio visualization pops up for a short while when starting a video. I think this is the reason for that.

This comment has been minimized.

Show comment Hide comment
@arnova

arnova Mar 15, 2013

Member

IMO should certainly be the same for HasAudio, just for consistency. I do wonder whether this is a good solution, we might as well check for eg. m_CurrentVideo.id > 0 then, right?

Member

arnova replied Mar 15, 2013

IMO should certainly be the same for HasAudio, just for consistency. I do wonder whether this is a good solution, we might as well check for eg. m_CurrentVideo.id > 0 then, right?

This comment has been minimized.

Show comment Hide comment
@theuni

theuni Mar 15, 2013

Member

@FernetMenta IMO the reason it pops up is because we use m_bStop to control IsPlaying(). Looks to me like it'd be worth keeping track of a bool for when playback has actually started.

Member

theuni replied Mar 15, 2013

@FernetMenta IMO the reason it pops up is because we use m_bStop to control IsPlaying(). Looks to me like it'd be worth keeping track of a bool for when playback has actually started.

This comment has been minimized.

Show comment Hide comment
@FernetMenta

FernetMenta Mar 15, 2013

Member

m_CurrentVideo.id > 0

We just dropped that because it didn't work for pvr. When changing channels there are no open streams.

EDIT: oh, you mean OR this condition?

Member

FernetMenta replied Mar 15, 2013

m_CurrentVideo.id > 0

We just dropped that because it didn't work for pvr. When changing channels there are no open streams.

EDIT: oh, you mean OR this condition?

This comment has been minimized.

Show comment Hide comment
@arnova

arnova Mar 16, 2013

Member

Nope, didn't mean OR. Are you sure there isn't any stuff that depends on the fact that HasVideo() means an actual video stream is available?

Member

arnova replied Mar 16, 2013

Nope, didn't mean OR. Are you sure there isn't any stuff that depends on the fact that HasVideo() means an actual video stream is available?

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Mar 16, 2013

Member
Member

elupus replied Mar 16, 2013

This comment has been minimized.

Show comment Hide comment
@FernetMenta

FernetMenta Mar 16, 2013

Member

elupus, anything you want to to do here for now?

Member

FernetMenta replied Mar 16, 2013

elupus, anything you want to to do here for now?

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Mar 17, 2013

Member
Member

elupus replied Mar 17, 2013

This comment has been minimized.

Show comment Hide comment
@FernetMenta

FernetMenta Mar 17, 2013

Member

We could set the bool to false in CloseVideo/AudioStream unless a channel switch is active. When the channel change is completed we receive a SPECIALID_STREAMCHANGE and call OpenDefaultStreams again. The bool would be set to false for obsolete streams.
What it the best method to detect a channel change in progress?

Member

FernetMenta replied Mar 17, 2013

We could set the bool to false in CloseVideo/AudioStream unless a channel switch is active. When the channel change is completed we receive a SPECIALID_STREAMCHANGE and call OpenDefaultStreams again. The bool would be set to false for obsolete streams.
What it the best method to detect a channel change in progress?

This comment has been minimized.

Show comment Hide comment
@elupus

elupus Mar 17, 2013

Member

Not in Close*Stream(). That would be racy, dvd's will close and reopen streams all the time. We should really just update it on STREAMCHANGE for those that support that.

Member

elupus replied Mar 17, 2013

Not in Close*Stream(). That would be racy, dvd's will close and reopen streams all the time. We should really just update it on STREAMCHANGE for those that support that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment