Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

[AE/OSX] Plug minor memory leak in CoreAudioAEStream #2432

Merged
merged 1 commit into from

3 participants

Tobias Hieta huceke davilla
Tobias Hieta

This buffer was not deallocated in the destructor.

huceke
Collaborator

I think you mean m_upmixBuffer and not m_upmixBufferSize.

Tobias Hieta

Ah, that's what you get for copy and pasting stuff into a clean tree. Will update it.

Tobias Hieta

Fixed.

huceke
Collaborator

@Memphiz, @davilla : Looks ok to me.

davilla davilla merged commit 0dcfd02 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 13, 2013
  1. Tobias Hieta
This page is out of date. Refresh to see the latest.
1  xbmc/cores/AudioEngine/Engines/CoreAudio/CoreAudioAEStream.cpp
View
@@ -148,6 +148,7 @@ CCoreAudioAEStream::~CCoreAudioAEStream()
//_aligned_free(m_resampleBuffer); m_resampleBuffer = NULL;
_aligned_free(m_remapBuffer); m_remapBuffer = NULL;
_aligned_free(m_vizRemapBuffer); m_vizRemapBuffer = NULL;
+ _aligned_free(m_upmixBuffer); m_upmixBuffer = NULL;
delete m_Buffer; m_Buffer = NULL;
Something went wrong with that request. Please try again.